From: Devang Patel Date: Tue, 13 Oct 2009 17:02:04 +0000 (+0000) Subject: Do not check use_empty() before invoking replaceAllUsesWith(). X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=3b122bc5f1203615e2128e0c1a63da438865b1cc;p=clang Do not check use_empty() before invoking replaceAllUsesWith(). Let replaceAllUsesWith() adjust VHs even though there are no uses. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@83978 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/CodeGen/CodeGenModule.cpp b/lib/CodeGen/CodeGenModule.cpp index f49a3de32b..a7a9805452 100644 --- a/lib/CodeGen/CodeGenModule.cpp +++ b/lib/CodeGen/CodeGenModule.cpp @@ -1110,8 +1110,9 @@ static void ReplaceUsesOfNonProtoTypeWithRealFunction(llvm::GlobalValue *Old, NewCall->setCallingConv(CI->getCallingConv()); // Finally, remove the old call, replacing any uses with the new one. - if (!CI->use_empty()) - CI->replaceAllUsesWith(NewCall); + CI->replaceAllUsesWith(NewCall); + + CI->eraseFromParent(); } }