From: Steve Naroff Date: Thu, 16 Apr 2009 19:02:57 +0000 (+0000) Subject: Fix clang-6: clang does not appear to support declaring... X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=3aaa482ea5b8d20b705f6ac8573b539be88d273a;p=clang Fix clang-6: clang does not appear to support declaring a static Block 'const'. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@69306 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/AST/Expr.cpp b/lib/AST/Expr.cpp index 9e8958c073..083bf3b808 100644 --- a/lib/AST/Expr.cpp +++ b/lib/AST/Expr.cpp @@ -854,6 +854,8 @@ bool Expr::hasGlobalStorage() const { switch (getStmtClass()) { default: return false; + case BlockExprClass: + return true; case ParenExprClass: return cast(this)->getSubExpr()->hasGlobalStorage(); case ImplicitCastExprClass: diff --git a/lib/AST/ExprConstant.cpp b/lib/AST/ExprConstant.cpp index 327fff0c0b..8fd75f1808 100644 --- a/lib/AST/ExprConstant.cpp +++ b/lib/AST/ExprConstant.cpp @@ -156,6 +156,7 @@ public: APValue VisitParenExpr(ParenExpr *E) { return Visit(E->getSubExpr()); } APValue VisitDeclRefExpr(DeclRefExpr *E); + APValue VisitBlockExpr(BlockExpr *E); APValue VisitPredefinedExpr(PredefinedExpr *E) { return APValue(E, 0); } APValue VisitCompoundLiteralExpr(CompoundLiteralExpr *E); APValue VisitMemberExpr(MemberExpr *E); @@ -184,6 +185,14 @@ APValue LValueExprEvaluator::VisitDeclRefExpr(DeclRefExpr *E) return APValue(E, 0); } +APValue LValueExprEvaluator::VisitBlockExpr(BlockExpr *E) +{ + if (E->hasBlockDeclRefExprs()) + return APValue(); + + return APValue(E, 0); +} + APValue LValueExprEvaluator::VisitCompoundLiteralExpr(CompoundLiteralExpr *E) { if (E->isFileScope()) return APValue(E, 0); @@ -373,6 +382,7 @@ APValue PointerExprEvaluator::VisitCastExpr(const CastExpr* E) { } if (SubExpr->getType()->isFunctionType() || + SubExpr->getType()->isBlockPointerType() || SubExpr->getType()->isArrayType()) { APValue Result; if (EvaluateLValue(SubExpr, Result, Info)) diff --git a/test/Sema/block-literal.c b/test/Sema/block-literal.c index 2dc4581243..040c383033 100644 --- a/test/Sema/block-literal.c +++ b/test/Sema/block-literal.c @@ -81,6 +81,12 @@ void test_arguments() { static int global_x = 10; void (^global_block)(void) = ^{ printf("global x is %d\n", global_x); }; +typedef void (^void_block_t)(void); + +static const void_block_t myBlock = ^{ }; + +static const void_block_t myBlock2 = ^ void(void) { }; + #if 0 // Old syntax. FIXME: convert/test. void test_byref() {