From: Andres Freund Date: Tue, 3 Feb 2015 22:52:15 +0000 (+0100) Subject: Remove ill-conceived Assertion in ProcessClientWriteInterrupt(). X-Git-Tag: REL9_5_ALPHA1~808 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=3a54f4a4944b849846c5a1494810ea06bd6601b7;p=postgresql Remove ill-conceived Assertion in ProcessClientWriteInterrupt(). It's perfectly fine to have blocked interrupts when ProcessClientWriteInterrupt() is called. In fact it's commonly the case when emitting error reports. And we deal with that correctly. Even if that'd not be the case, it'd be a bad location for such a assertion. Because ProcessClientWriteInterrupt() is only called when the socket is blocked it's hard to hit. Per Heikki and buildfarm animals nightjar and dunlin. --- diff --git a/src/backend/tcop/postgres.c b/src/backend/tcop/postgres.c index f2a426d792..28af40c3dc 100644 --- a/src/backend/tcop/postgres.c +++ b/src/backend/tcop/postgres.c @@ -571,8 +571,6 @@ ProcessClientWriteInterrupt(bool blocked) { int save_errno = errno; - Assert(InterruptHoldoffCount == 0 && CritSectionCount == 0); - /* * We only want to process the interrupt here if socket writes are * blocking to increase the chance to get an error message to the