From: Simon Riggs Date: Thu, 24 Jan 2013 14:25:28 +0000 (+0000) Subject: Fix rare missing cancellations in Hot Standby. X-Git-Tag: REL9_0_12~14 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=3a25b2d70c28942cf2c5e4d90d3a643baf845dfc;p=postgresql Fix rare missing cancellations in Hot Standby. The machinery around XLOG_HEAP2_CLEANUP_INFO failed to correctly pass through the necessary information on latestRemovedXid, avoiding cancellations in some infrequent concurrent update/cleanup scenarios. Backpatchable fix to 9.0 Detailed bug report and fix by Noah Misch, backpatchable version by me. --- diff --git a/src/backend/access/heap/pruneheap.c b/src/backend/access/heap/pruneheap.c index 6d72bb2765..cc3f8b90e1 100644 --- a/src/backend/access/heap/pruneheap.c +++ b/src/backend/access/heap/pruneheap.c @@ -173,7 +173,7 @@ heap_page_prune(Relation relation, Buffer buffer, TransactionId OldestXmin, * initialize the rest of our working state. */ prstate.new_prune_xid = InvalidTransactionId; - prstate.latestRemovedXid = InvalidTransactionId; + prstate.latestRemovedXid = *latestRemovedXid; prstate.nredirected = prstate.ndead = prstate.nunused = 0; memset(prstate.marked, 0, sizeof(prstate.marked));