From: sr55 <sr55.hb@outlook.com>
Date: Mon, 26 Jun 2017 19:41:20 +0000 (+0100)
Subject: WinGui: AutoName Sort the InvalidFileNameChars Array before doing a Binary Search... 
X-Git-Tag: 1.1.0~482
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=3a0b7d29770107658ba13e365a8550cd3dc0e40e;p=handbrake

WinGui: AutoName Sort the InvalidFileNameChars Array before doing a Binary Search on it.
---

diff --git a/win/CS/HandBrakeWPF/ViewModels/OptionsViewModel.cs b/win/CS/HandBrakeWPF/ViewModels/OptionsViewModel.cs
index c62161264..5d936be0c 100644
--- a/win/CS/HandBrakeWPF/ViewModels/OptionsViewModel.cs
+++ b/win/CS/HandBrakeWPF/ViewModels/OptionsViewModel.cs
@@ -1542,10 +1542,11 @@ namespace HandBrakeWPF.ViewModels
         /// <returns>True if valid</returns>
         private bool IsValidAutonameFormat(string input, bool isSilent)
         {
+            char[] invalidchars = Path.GetInvalidFileNameChars();
+            Array.Sort(invalidchars);
             foreach (var characterToTest in input)
             {
-                // we binary search for the character in the invalid set. This should be lightning fast.
-                if (Array.BinarySearch(Path.GetInvalidFileNameChars(), characterToTest) >= 0)
+                if (Array.BinarySearch(invalidchars, characterToTest) >= 0)
                 {
                     if (!isSilent)
                     {