From: Andres Freund <andres@anarazel.de>
Date: Sun, 4 Jan 2015 14:35:47 +0000 (+0100)
Subject: Add missing va_end() call to a early exit in dmetaphone.c's StringAt().
X-Git-Tag: REL9_1_15~39
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=39cdf365a38416f2f31429db9656ccfcb65ccd69;p=postgresql

Add missing va_end() call to a early exit in dmetaphone.c's StringAt().

Pointed out by Coverity.

Backpatch to all supported branches, the code has been that way for a
long while.
---

diff --git a/contrib/fuzzystrmatch/dmetaphone.c b/contrib/fuzzystrmatch/dmetaphone.c
index 6721e58f22..5ad2ed532a 100644
--- a/contrib/fuzzystrmatch/dmetaphone.c
+++ b/contrib/fuzzystrmatch/dmetaphone.c
@@ -362,7 +362,10 @@ StringAt(metastring *s, int start, int length,...)
 	{
 		test = va_arg(ap, char *);
 		if (*test && (strncmp(pos, test, length) == 0))
+		{
+			va_end(ap);
 			return 1;
+		}
 	}
 	while (strcmp(test, ""));