From: Todd C. Miller <Todd.Miller@courtesan.com>
Date: Thu, 15 Apr 2010 10:14:41 +0000 (-0400)
Subject: Fix use after free in error message when a duplicate alias exists.
X-Git-Tag: SUDO_1_8_0~719
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=399aa0d5c77d6ed3191d143d370388a173db07e5;p=sudo

Fix use after free in error message when a duplicate alias exists.
---

diff --git a/plugins/sudoers/alias.c b/plugins/sudoers/alias.c
index 2ca8add30..578c30228 100644
--- a/plugins/sudoers/alias.c
+++ b/plugins/sudoers/alias.c
@@ -121,8 +121,8 @@ alias_add(name, type, members)
     a->seqno = 0;
     list2tq(&a->members, members);
     if (rbinsert(aliases, a)) {
-	alias_free(a);
 	snprintf(errbuf, sizeof(errbuf), "Alias `%s' already defined", name);
+	alias_free(a);
 	return(errbuf);
     }
     return(NULL);