From: Fariborz Jahanian Date: Wed, 21 Oct 2009 21:01:47 +0000 (+0000) Subject: Expand on code gen. for pointer to data members so it works X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=39762951ad2abfed7b743c01c672fac85034b856;p=clang Expand on code gen. for pointer to data members so it works for base classe members as well. Test case enhanced for this. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@84780 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/CodeGen/CGExpr.cpp b/lib/CodeGen/CGExpr.cpp index 2266b25c68..0b56fa94b7 100644 --- a/lib/CodeGen/CGExpr.cpp +++ b/lib/CodeGen/CGExpr.cpp @@ -1519,9 +1519,10 @@ LValue CodeGenFunction::EmitStmtExprLValue(const StmtExpr *E) { LValue CodeGenFunction::EmitPointerToDataMemberLValue( const QualifiedDeclRefExpr *E) { const FieldDecl *Field = cast(E->getDecl()); - const NestedNameSpecifier *NNSpec = E->getQualifier(); - const Type *NNSpecType = NNSpec->getAsType(); - QualType NNSpecTy = getContext().getCanonicalType(QualType(NNSpecType, 0)); + const CXXRecordDecl *ClassDecl = cast(Field->getDeclContext()); + QualType NNSpecTy = + getContext().getCanonicalType( + getContext().getTypeDeclType(const_cast(ClassDecl))); NNSpecTy = getContext().getPointerType(NNSpecTy); llvm::Value *V = llvm::Constant::getNullValue(ConvertType(NNSpecTy)); LValue MemExpLV = EmitLValueForField(V, const_cast(Field), diff --git a/test/CodeGenCXX/ptr-to-datamember.cpp b/test/CodeGenCXX/ptr-to-datamember.cpp index 86c771a8b0..7e945a20dc 100644 --- a/test/CodeGenCXX/ptr-to-datamember.cpp +++ b/test/CodeGenCXX/ptr-to-datamember.cpp @@ -2,9 +2,23 @@ extern "C" int printf(...); -class A { +struct V { + double d; + int iV; +}; + +struct B : virtual V{ + double d; + int iB; +}; + +struct B1 : virtual V{ + double d; + int iB1; +}; + +class A : public B, public B1 { public: - A() : f(1.0), d(2.0), Ai(100) {} float f; double d; int Ai; @@ -17,9 +31,13 @@ int main() float A::* pf = &A::f; double A::* pd = &A::d; printf("%d %d %d\n", &A::Ai, &A::f, &A::d); - + printf("%d\n", &A::B::iB); + printf("%d\n", &A::B1::iB1); + printf("%d\n", &A::f); + printf("%d\n", &A::B::iV); + printf("%d\n", &A::B1::iV); + printf("%d\n", &A::B::V::iV); + printf("%d\n", &A::B1::V::iV); // FIXME. NYI // printf(" %d, %f, %f \n", a1.*pa, a1.f, a1.d); } - -