From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Tue, 7 Apr 2015 20:56:21 +0000 (-0400)
Subject: Fix assorted inconsistent function declarations.
X-Git-Tag: REL9_5_ALPHA1~476
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=393de3a09868458dfb7ef765c544c34624ea1da2;p=postgresql

Fix assorted inconsistent function declarations.

While gcc doesn't complain if you declare a function "static" and then
define it not-static, other compilers do; and in any case the code is
highly misleading this way.  Add the missing "static" keywords to a
couple of recent patches.  Per buildfarm member pademelon.
---

diff --git a/src/bin/pg_rewind/parsexlog.c b/src/bin/pg_rewind/parsexlog.c
index 3cf96abd08..715aaab42a 100644
--- a/src/bin/pg_rewind/parsexlog.c
+++ b/src/bin/pg_rewind/parsexlog.c
@@ -229,7 +229,7 @@ findLastCheckpoint(const char *datadir, XLogRecPtr forkptr, TimeLineID tli,
 }
 
 /* XLogreader callback function, to read a WAL page */
-int
+static int
 SimpleXLogPageRead(XLogReaderState *xlogreader, XLogRecPtr targetPagePtr,
 				   int reqLen, XLogRecPtr targetRecPtr, char *readBuf,
 				   TimeLineID *pageTLI)