From: Mukund Sivaraman <muks@mukund.org>
Date: Thu, 14 Aug 2008 10:39:27 +0000 (+0000)
Subject: Fix leak of torrents
X-Git-Tag: 1.40~510
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=3895b39d60aab742d3b4db04307063cae541bc02;p=transmission

Fix leak of torrents
---

diff --git a/libtransmission/rpc.c b/libtransmission/rpc.c
index b5357cebf..945086101 100644
--- a/libtransmission/rpc.c
+++ b/libtransmission/rpc.c
@@ -363,15 +363,19 @@ torrentGet( tr_handle * handle, tr_benc * args_in, tr_benc * args_out )
     tr_torrent ** torrents = getTorrents( handle, args_in, &torrentCount );
     tr_benc * list = tr_bencDictAddList( args_out, "torrents", torrentCount );
     tr_benc * fields;
+    char *msg = NULL;
 
-    if( !tr_bencDictFindList( args_in, "fields", &fields ) )
-        return "no fields specified";
+    if( !tr_bencDictFindList( args_in, "fields", &fields ) ) {
+        msg = "no fields specified";
+        goto out;
+    }
 
     for( i=0; i<torrentCount; ++i )
         addInfo( torrents[i], tr_bencListAdd( list ), fields );
 
+out:
     tr_free( torrents );
-    return NULL;
+    return msg;
 }
 
 /***