From: swaldhoer <34184299+swaldhoer@users.noreply.github.com> Date: Sat, 20 Feb 2021 19:25:50 +0000 (+0100) Subject: Add Python dependencies as requirements.txt X-Git-Tag: 2.47.0~39^2 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=383ec8753b8007d26fc4f6eb51c61b6d8b71d12e;p=graphviz Add Python dependencies as requirements.txt Add linting of Python scripts --- diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index ca887acc0..7b474d1e5 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -510,7 +510,7 @@ fedora33-test: macos-autotools-test: <<: *test_definition before_script: - - pip3 install pytest + - python3 -m pip install --requirement requirements.txt - export build_system="autotools" - echo experimental > COLLECTION needs: @@ -594,7 +594,7 @@ fedora32-cmake-test: macos-cmake-test: <<: *test_definition before_script: - - pip3 install pytest + - python3 -m pip install --requirement requirements.txt - export build_system="cmake" - echo experimental > COLLECTION needs: @@ -740,3 +740,11 @@ docker_push_ubuntu-20.10: <<: *docker_push_definition variables: IMAGE: ubuntu-20.10 + +lint_pylint: + image: "$CI_REGISTRY_IMAGE/ubuntu-20.10:$CI_COMMIT_SHA" + stage: test + needs: + - docker_build_ubuntu-20.10 + script: + - python3 -m pylint --rcfile=.pylintrc `find . -name '*.py' | xargs` --exit-zero diff --git a/.pylintrc b/.pylintrc new file mode 100644 index 000000000..8f4ebd796 --- /dev/null +++ b/.pylintrc @@ -0,0 +1,588 @@ +[MASTER] + +# A comma-separated list of package or module names from where C extensions may +# be loaded. Extensions are loading into the active Python interpreter and may +# run arbitrary code. +extension-pkg-whitelist= + +# Specify a score threshold to be exceeded before program exits with error. +fail-under=10.0 + +# Add files or directories to the blacklist. They should be base names, not +# paths. +ignore=CVS + +# Add files or directories matching the regex patterns to the blacklist. The +# regex matches against base names, not paths. +ignore-patterns= + +# Python code to execute, usually for sys.path manipulation such as +# pygtk.require(). +#init-hook= + +# Use multiple processes to speed up Pylint. Specifying 0 will auto-detect the +# number of processors available to use. +jobs=1 + +# Control the amount of potential inferred values when inferring a single +# object. This can help the performance when dealing with large functions or +# complex, nested conditions. +limit-inference-results=100 + +# List of plugins (as comma separated values of python module names) to load, +# usually to register additional checkers. +load-plugins= + +# Pickle collected data for later comparisons. +persistent=yes + +# When enabled, pylint would attempt to guess common misconfiguration and emit +# user-friendly hints instead of false-positive error messages. +suggestion-mode=yes + +# Allow loading of arbitrary C extensions. Extensions are imported into the +# active Python interpreter and may run arbitrary code. +unsafe-load-any-extension=no + + +[MESSAGES CONTROL] + +# Only show warnings with the listed confidence levels. Leave empty to show +# all. Valid levels: HIGH, INFERENCE, INFERENCE_FAILURE, UNDEFINED. +confidence= + +# Disable the message, report, category or checker with the given id(s). You +# can either give multiple identifiers separated by comma (,) or put this +# option multiple times (only on the command line, not in the configuration +# file where it should appear only once). You can also use "--disable=all" to +# disable everything first and then reenable specific checks. For example, if +# you want to run only the similarities checker, you can use "--disable=all +# --enable=similarities". If you want to run only the classes checker, but have +# no Warning level messages displayed, use "--disable=all --enable=classes +# --disable=W". +disable=print-statement, + parameter-unpacking, + unpacking-in-except, + old-raise-syntax, + backtick, + long-suffix, + old-ne-operator, + old-octal-literal, + import-star-module-level, + non-ascii-bytes-literal, + raw-checker-failed, + bad-inline-option, + locally-disabled, + file-ignored, + suppressed-message, + useless-suppression, + deprecated-pragma, + use-symbolic-message-instead, + apply-builtin, + basestring-builtin, + buffer-builtin, + cmp-builtin, + coerce-builtin, + execfile-builtin, + file-builtin, + long-builtin, + raw_input-builtin, + reduce-builtin, + standarderror-builtin, + unicode-builtin, + xrange-builtin, + coerce-method, + delslice-method, + getslice-method, + setslice-method, + no-absolute-import, + old-division, + dict-iter-method, + dict-view-method, + next-method-called, + metaclass-assignment, + indexing-exception, + raising-string, + reload-builtin, + oct-method, + hex-method, + nonzero-method, + cmp-method, + input-builtin, + round-builtin, + intern-builtin, + unichr-builtin, + map-builtin-not-iterating, + zip-builtin-not-iterating, + range-builtin-not-iterating, + filter-builtin-not-iterating, + using-cmp-argument, + eq-without-hash, + div-method, + idiv-method, + rdiv-method, + exception-message-attribute, + invalid-str-codec, + sys-max-int, + bad-python3-import, + deprecated-string-function, + deprecated-str-translate-call, + deprecated-itertools-function, + deprecated-types-field, + next-method-defined, + dict-items-not-iterating, + dict-keys-not-iterating, + dict-values-not-iterating, + deprecated-operator-function, + deprecated-urllib-function, + xreadlines-attribute, + deprecated-sys-function, + exception-escape, + comprehension-escape + +# Enable the message, report, category or checker with the given id(s). You can +# either give multiple identifier separated by comma (,) or put this option +# multiple time (only on the command line, not in the configuration file where +# it should appear only once). See also the "--disable" option for examples. +enable=c-extension-no-member + + +[REPORTS] + +# Python expression which should return a score less than or equal to 10. You +# have access to the variables 'error', 'warning', 'refactor', and 'convention' +# which contain the number of messages in each category, as well as 'statement' +# which is the total number of statements analyzed. This score is used by the +# global evaluation report (RP0004). +evaluation=10.0 - ((float(5 * error + warning + refactor + convention) / statement) * 10) + +# Template used to display messages. This is a python new-style format string +# used to format the message information. See doc for all details. +#msg-template= + +# Set the output format. Available formats are text, parseable, colorized, json +# and msvs (visual studio). You can also give a reporter class, e.g. +# mypackage.mymodule.MyReporterClass. +output-format=text + +# Tells whether to display a full report or only the messages. +reports=no + +# Activate the evaluation score. +score=yes + + +[REFACTORING] + +# Maximum number of nested blocks for function / method body +max-nested-blocks=5 + +# Complete name of functions that never returns. When checking for +# inconsistent-return-statements if a never returning function is called then +# it will be considered as an explicit return statement and no message will be +# printed. +never-returning-functions=sys.exit + + +[BASIC] + +# Naming style matching correct argument names. +argument-naming-style=snake_case + +# Regular expression matching correct argument names. Overrides argument- +# naming-style. +#argument-rgx= + +# Naming style matching correct attribute names. +attr-naming-style=snake_case + +# Regular expression matching correct attribute names. Overrides attr-naming- +# style. +#attr-rgx= + +# Bad variable names which should always be refused, separated by a comma. +bad-names=foo, + bar, + baz, + toto, + tutu, + tata + +# Bad variable names regexes, separated by a comma. If names match any regex, +# they will always be refused +bad-names-rgxs= + +# Naming style matching correct class attribute names. +class-attribute-naming-style=any + +# Regular expression matching correct class attribute names. Overrides class- +# attribute-naming-style. +#class-attribute-rgx= + +# Naming style matching correct class names. +class-naming-style=PascalCase + +# Regular expression matching correct class names. Overrides class-naming- +# style. +#class-rgx= + +# Naming style matching correct constant names. +const-naming-style=UPPER_CASE + +# Regular expression matching correct constant names. Overrides const-naming- +# style. +#const-rgx= + +# Minimum line length for functions/classes that require docstrings, shorter +# ones are exempt. +docstring-min-length=-1 + +# Naming style matching correct function names. +function-naming-style=snake_case + +# Regular expression matching correct function names. Overrides function- +# naming-style. +#function-rgx= + +# Good variable names which should always be accepted, separated by a comma. +good-names=i, + j, + k, + ex, + Run, + _ + +# Good variable names regexes, separated by a comma. If names match any regex, +# they will always be accepted +good-names-rgxs= + +# Include a hint for the correct naming format with invalid-name. +include-naming-hint=no + +# Naming style matching correct inline iteration names. +inlinevar-naming-style=any + +# Regular expression matching correct inline iteration names. Overrides +# inlinevar-naming-style. +#inlinevar-rgx= + +# Naming style matching correct method names. +method-naming-style=snake_case + +# Regular expression matching correct method names. Overrides method-naming- +# style. +#method-rgx= + +# Naming style matching correct module names. +module-naming-style=snake_case + +# Regular expression matching correct module names. Overrides module-naming- +# style. +#module-rgx= + +# Colon-delimited sets of names that determine each other's naming style when +# the name regexes allow several styles. +name-group= + +# Regular expression which should only match function or class names that do +# not require a docstring. +no-docstring-rgx=^_ + +# List of decorators that produce properties, such as abc.abstractproperty. Add +# to this list to register other decorators that produce valid properties. +# These decorators are taken in consideration only for invalid-name. +property-classes=abc.abstractproperty + +# Naming style matching correct variable names. +variable-naming-style=snake_case + +# Regular expression matching correct variable names. Overrides variable- +# naming-style. +#variable-rgx= + + +[FORMAT] + +# Expected format of line ending, e.g. empty (any line ending), LF or CRLF. +expected-line-ending-format= + +# Regexp for a line that is allowed to be longer than the limit. +ignore-long-lines=^\s*(# )??$ + +# Number of spaces of indent required inside a hanging or continued line. +indent-after-paren=4 + +# String used as indentation unit. This is usually " " (4 spaces) or "\t" (1 +# tab). +indent-string=' ' + +# Maximum number of characters on a single line. +max-line-length=100 + +# Maximum number of lines in a module. +max-module-lines=1000 + +# Allow the body of a class to be on the same line as the declaration if body +# contains single statement. +single-line-class-stmt=no + +# Allow the body of an if to be on the same line as the test if there is no +# else. +single-line-if-stmt=no + + +[LOGGING] + +# The type of string formatting that logging methods do. `old` means using % +# formatting, `new` is for `{}` formatting. +logging-format-style=old + +# Logging modules to check that the string format arguments are in logging +# function parameter format. +logging-modules=logging + + +[MISCELLANEOUS] + +# List of note tags to take in consideration, separated by a comma. +notes=FIXME, + XXX, + TODO + +# Regular expression of note tags to take in consideration. +#notes-rgx= + + +[SIMILARITIES] + +# Ignore comments when computing similarities. +ignore-comments=yes + +# Ignore docstrings when computing similarities. +ignore-docstrings=yes + +# Ignore imports when computing similarities. +ignore-imports=no + +# Minimum lines number of a similarity. +min-similarity-lines=4 + + +[SPELLING] + +# Limits count of emitted suggestions for spelling mistakes. +max-spelling-suggestions=4 + +# Spelling dictionary name. Available dictionaries: none. To make it work, +# install the python-enchant package. +spelling-dict= + +# List of comma separated words that should not be checked. +spelling-ignore-words= + +# A path to a file that contains the private dictionary; one word per line. +spelling-private-dict-file= + +# Tells whether to store unknown words to the private dictionary (see the +# --spelling-private-dict-file option) instead of raising a message. +spelling-store-unknown-words=no + + +[STRING] + +# This flag controls whether inconsistent-quotes generates a warning when the +# character used as a quote delimiter is used inconsistently within a module. +check-quote-consistency=no + +# This flag controls whether the implicit-str-concat should generate a warning +# on implicit string concatenation in sequences defined over several lines. +check-str-concat-over-line-jumps=no + + +[TYPECHECK] + +# List of decorators that produce context managers, such as +# contextlib.contextmanager. Add to this list to register other decorators that +# produce valid context managers. +contextmanager-decorators=contextlib.contextmanager + +# List of members which are set dynamically and missed by pylint inference +# system, and so shouldn't trigger E1101 when accessed. Python regular +# expressions are accepted. +generated-members= + +# Tells whether missing members accessed in mixin class should be ignored. A +# mixin class is detected if its name ends with "mixin" (case insensitive). +ignore-mixin-members=yes + +# Tells whether to warn about missing members when the owner of the attribute +# is inferred to be None. +ignore-none=yes + +# This flag controls whether pylint should warn about no-member and similar +# checks whenever an opaque object is returned when inferring. The inference +# can return multiple potential results while evaluating a Python object, but +# some branches might not be evaluated, which results in partial inference. In +# that case, it might be useful to still emit no-member and other checks for +# the rest of the inferred objects. +ignore-on-opaque-inference=yes + +# List of class names for which member attributes should not be checked (useful +# for classes with dynamically set attributes). This supports the use of +# qualified names. +ignored-classes=optparse.Values,thread._local,_thread._local + +# List of module names for which member attributes should not be checked +# (useful for modules/projects where namespaces are manipulated during runtime +# and thus existing member attributes cannot be deduced by static analysis). It +# supports qualified module names, as well as Unix pattern matching. +ignored-modules= + +# Show a hint with possible names when a member name was not found. The aspect +# of finding the hint is based on edit distance. +missing-member-hint=yes + +# The minimum edit distance a name should have in order to be considered a +# similar match for a missing member name. +missing-member-hint-distance=1 + +# The total number of similar names that should be taken in consideration when +# showing a hint for a missing member. +missing-member-max-choices=1 + +# List of decorators that change the signature of a decorated function. +signature-mutators= + + +[VARIABLES] + +# List of additional names supposed to be defined in builtins. Remember that +# you should avoid defining new builtins when possible. +additional-builtins= + +# Tells whether unused global variables should be treated as a violation. +allow-global-unused-variables=yes + +# List of strings which can identify a callback function by name. A callback +# name must start or end with one of those strings. +callbacks=cb_, + _cb + +# A regular expression matching the name of dummy variables (i.e. expected to +# not be used). +dummy-variables-rgx=_+$|(_[a-zA-Z0-9_]*[a-zA-Z0-9]+?$)|dummy|^ignored_|^unused_ + +# Argument names that match this expression will be ignored. Default to name +# with leading underscore. +ignored-argument-names=_.*|^ignored_|^unused_ + +# Tells whether we should check for unused import in __init__ files. +init-import=no + +# List of qualified module names which can have objects that can redefine +# builtins. +redefining-builtins-modules=six.moves,past.builtins,future.builtins,builtins,io + + +[CLASSES] + +# List of method names used to declare (i.e. assign) instance attributes. +defining-attr-methods=__init__, + __new__, + setUp, + __post_init__ + +# List of member names, which should be excluded from the protected access +# warning. +exclude-protected=_asdict, + _fields, + _replace, + _source, + _make + +# List of valid names for the first argument in a class method. +valid-classmethod-first-arg=cls + +# List of valid names for the first argument in a metaclass class method. +valid-metaclass-classmethod-first-arg=cls + + +[DESIGN] + +# Maximum number of arguments for function / method. +max-args=5 + +# Maximum number of attributes for a class (see R0902). +max-attributes=7 + +# Maximum number of boolean expressions in an if statement (see R0916). +max-bool-expr=5 + +# Maximum number of branch for function / method body. +max-branches=12 + +# Maximum number of locals for function / method body. +max-locals=15 + +# Maximum number of parents for a class (see R0901). +max-parents=7 + +# Maximum number of public methods for a class (see R0904). +max-public-methods=20 + +# Maximum number of return / yield for function / method body. +max-returns=6 + +# Maximum number of statements in function / method body. +max-statements=50 + +# Minimum number of public methods for a class (see R0903). +min-public-methods=2 + + +[IMPORTS] + +# List of modules that can be imported at any level, not just the top level +# one. +allow-any-import-level= + +# Allow wildcard imports from modules that define __all__. +allow-wildcard-with-all=no + +# Analyse import fallback blocks. This can be used to support both Python 2 and +# 3 compatible code, which means that the block might have code that exists +# only in one or another interpreter, leading to false positives when analysed. +analyse-fallback-blocks=no + +# Deprecated modules which should not be used, separated by a comma. +deprecated-modules=optparse,tkinter.tix + +# Create a graph of external dependencies in the given file (report RP0402 must +# not be disabled). +ext-import-graph= + +# Create a graph of every (i.e. internal and external) dependencies in the +# given file (report RP0402 must not be disabled). +import-graph= + +# Create a graph of internal dependencies in the given file (report RP0402 must +# not be disabled). +int-import-graph= + +# Force import order to recognize a module as part of the standard +# compatibility libraries. +known-standard-library= + +# Force import order to recognize a module as part of a third party library. +known-third-party=enchant + +# Couples of modules and preferred modules, separated by a comma. +preferred-modules= + + +[EXCEPTIONS] + +# Exceptions that will emit a warning when being caught. Defaults to +# "BaseException, Exception". +overgeneral-exceptions=BaseException, + Exception diff --git a/ci/centos7/Dockerfile b/ci/centos7/Dockerfile index 216ce1f50..cba52c3a1 100644 --- a/ci/centos7/Dockerfile +++ b/ci/centos7/Dockerfile @@ -1,5 +1,7 @@ FROM centos:7 +COPY requirements.txt ./requirements.txt + # Development tools RUN yum -y groupinstall 'Development Tools' \ && yum install -y \ @@ -76,12 +78,16 @@ libSM-devel \ libXaw-devel \ tk-devel \ # Test utilities +python3-pip \ +python3-setuptools \ && rpm --install https://download-ib01.fedoraproject.org/pub/epel/7/x86_64/Packages/p/python36-py-1.4.32-2.el7.noarch.rpm \ -&& rpm --install https://download-ib01.fedoraproject.org/pub/epel/7/x86_64/Packages/p/python36-pytest-2.9.2-4.el7.noarch.rpm \ && alternatives --install /usr/local/bin/cmake cmake /usr/bin/cmake3 20 \ --slave /usr/local/bin/ctest ctest /usr/bin/ctest3 \ --slave /usr/local/bin/cpack cpack /usr/bin/cpack3 \ --slave /usr/local/bin/ccmake ccmake /usr/bin/ccmake3 \ --family cmake \ +# install Python dependencies +&& python3 -m pip install --user --upgrade pip \ +&& python3 -m pip install --user --requirement requirements.txt \ # Clean up && yum clean all && rm -rf /var/cache/yum diff --git a/ci/centos8/Dockerfile b/ci/centos8/Dockerfile index 41651743a..9657dc87b 100644 --- a/ci/centos8/Dockerfile +++ b/ci/centos8/Dockerfile @@ -1,5 +1,7 @@ FROM centos:8 +COPY requirements.txt ./requirements.txt + # Development tools RUN yum -y groupinstall 'Development Tools' \ && dnf config-manager --set-enabled powertools \ @@ -66,6 +68,10 @@ libSM-devel \ libXaw-devel \ tk-devel \ # Test utilities -python3-pytest \ +python3-pip \ +python3-setuptools \ +# install Python dependencies +&& python3 -m pip install --user --upgrade pip \ +&& python3 -m pip install --user --requirement requirements.txt \ # Clean up && yum clean all && rm -rf /var/cache/yum diff --git a/ci/fedora32/Dockerfile b/ci/fedora32/Dockerfile index 8d197135d..d04fc9a43 100644 --- a/ci/fedora32/Dockerfile +++ b/ci/fedora32/Dockerfile @@ -1,4 +1,7 @@ FROM fedora:32 + +COPY requirements.txt ./requirements.txt + # Development tools RUN yum -y groupinstall 'Development Tools' \ && yum -y install rpm-build \ @@ -69,6 +72,10 @@ glade3-libgladeui-devel \ libglade2-devel \ mono-core \ # Test utilities -python-pytest \ +python3-pip \ +python3-setuptools \ +# install Python dependencies +&& python3 -m pip install --user --upgrade pip \ +&& python3 -m pip install --user --requirement requirements.txt \ # Clean up -&& yum clean all && rm -rf /var/cache/yum \ +&& yum clean all && rm -rf /var/cache/yum diff --git a/ci/fedora33/Dockerfile b/ci/fedora33/Dockerfile index 79afbbb49..ad61e3233 100644 --- a/ci/fedora33/Dockerfile +++ b/ci/fedora33/Dockerfile @@ -1,5 +1,7 @@ FROM fedora:33 +COPY requirements.txt ./requirements.txt + # Development tools RUN yum -y groupinstall 'Development Tools' \ && yum -y install rpm-build \ @@ -71,6 +73,10 @@ libXaw-devel \ libglade2-devel \ mono-core \ # Test utilities -python-pytest \ +python3-pip \ +python3-setuptools \ +# install Python dependencies +&& python3 -m pip install --user --upgrade pip \ +&& python3 -m pip install --user --requirement requirements.txt \ # Clean up -&& yum clean all && rm -rf /var/cache/yum \ +&& yum clean all && rm -rf /var/cache/yum diff --git a/ci/ubuntu-18.04/Dockerfile b/ci/ubuntu-18.04/Dockerfile index 79055817c..51b6bebc1 100644 --- a/ci/ubuntu-18.04/Dockerfile +++ b/ci/ubuntu-18.04/Dockerfile @@ -2,6 +2,8 @@ FROM ubuntu:18.04 ARG DEBIAN_FRONTEND=noninteractive +COPY requirements.txt ./requirements.txt + RUN apt-get update -y \ && apt-get install --no-install-recommends -y \ # Development tools @@ -77,7 +79,11 @@ ruby-dev \ # Language extension gv_tcl tcl-dev \ # Test utilities -python3-pytest \ ksh \ +python3-pip \ +python3-setuptools \ +# install Python dependencies +&& python3 -m pip install --user --upgrade pip \ +&& python3 -m pip install --user --requirement requirements.txt \ # Clean up && rm -rf /var/lib/apt/lists/* diff --git a/ci/ubuntu-20.04/Dockerfile b/ci/ubuntu-20.04/Dockerfile index 377fdb1d4..e80dc371b 100644 --- a/ci/ubuntu-20.04/Dockerfile +++ b/ci/ubuntu-20.04/Dockerfile @@ -2,6 +2,8 @@ FROM ubuntu:20.04 ARG DEBIAN_FRONTEND=noninteractive +COPY requirements.txt ./requirements.txt + RUN apt-get update -y \ && apt-get install --no-install-recommends -y \ # Development tools @@ -77,6 +79,10 @@ ruby-dev \ # Language extension gv_tcl tcl-dev \ # Test utilities -python3-pytest \ +python3-pip \ +python3-setuptools \ +# install Python dependencies +&& python3 -m pip install --user --upgrade pip \ +&& python3 -m pip install --user --requirement requirements.txt \ # Clean up && rm -rf /var/lib/apt/lists/* diff --git a/ci/ubuntu-20.10/Dockerfile b/ci/ubuntu-20.10/Dockerfile index 324d3f360..497269704 100644 --- a/ci/ubuntu-20.10/Dockerfile +++ b/ci/ubuntu-20.10/Dockerfile @@ -2,6 +2,8 @@ FROM ubuntu:20.10 ARG DEBIAN_FRONTEND=noninteractive +COPY requirements.txt ./requirements.txt + RUN apt-get update -y \ && apt-get install --no-install-recommends -y \ # Development tools @@ -79,6 +81,10 @@ ruby-dev \ # Language extension gv_tcl tcl-dev \ # Test utilities -python3-pytest \ +python3-pip \ +python3-setuptools \ +# install Python dependencies +&& python3 -m pip install --user --upgrade pip \ +&& python3 -m pip install --user --requirement requirements.txt \ # Clean up && rm -rf /var/lib/apt/lists/* diff --git a/requirements.txt b/requirements.txt new file mode 100644 index 000000000..440bc51d7 --- /dev/null +++ b/requirements.txt @@ -0,0 +1,2 @@ +pylint==2.6.2 +pytest==6.2.2