From: Zeev Suraski <zeev@php.net>
Date: Wed, 5 Jul 2000 20:41:06 +0000 (+0000)
Subject: That's no bug, it's quite fine the way it is (if id is
X-Git-Tag: PRE_METHOD_CALL_SEPERATE_FIX_PATCH~13
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=37de6635b4c341ec853a0eaef33bf0c47c985751;p=php

That's no bug, it's quite fine the way it is (if id is
set to -1, it's ignored, and the passed_id argument is used).

If you're experiencing trouble with mysql_close(), please give me a
reproducing script.  If there's a bug, it's not as simple as that.
---

diff --git a/ext/mysql/php_mysql.c b/ext/mysql/php_mysql.c
index 3a3747bee8..ac87d54226 100644
--- a/ext/mysql/php_mysql.c
+++ b/ext/mysql/php_mysql.c
@@ -598,9 +598,6 @@ PHP_FUNCTION(mysql_close)
 	}
 	
 	ZEND_FETCH_RESOURCE2(mysql, MYSQL *, mysql_link, id, "MySQL-Link", le_link, le_plink);
-
-	/* XXX shouldn't this be zend_list_delete((*mysql_link)->value.lval)
-	 * if the optional parameter is present? (steinm@php.net) */
 	zend_list_delete(id);
 	RETURN_TRUE;
 }