From: Bert Hubert <bert.hubert@netherlabs.nl>
Date: Thu, 30 Dec 2010 14:39:47 +0000 (+0000)
Subject: silence some debugging output, clarify some comments
X-Git-Tag: auth-3.0~479
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=379005d396729b325b63bacedec42b85ff1721bb;p=pdns

silence some debugging output, clarify some comments


git-svn-id: svn://svn.powerdns.com/pdns/trunk/pdns@1768 d19b8d6e-7fed-0310-83ef-9ca221ded41b
---

diff --git a/pdns/dnspacket.cc b/pdns/dnspacket.cc
index d3b42c897..10afcc0c0 100644
--- a/pdns/dnspacket.cc
+++ b/pdns/dnspacket.cc
@@ -352,7 +352,7 @@ void DNSPacket::wrapup(void)
       vector<shared_ptr<DNSRecordContent> > toSign;
 
       for(pos=d_rrs.begin(); pos < d_rrs.end(); ++pos) {
-        // this needs to deal with the 'prio' mismatch!
+        // this needs to deal with the 'prio' mismatch:
         if(pos->qtype.getCode()==QType::MX || pos->qtype.getCode() == QType::SRV) {  
           pos->content = lexical_cast<string>(pos->priority) + " " + pos->content;
         }
diff --git a/pdns/dnssecinfra.cc b/pdns/dnssecinfra.cc
index a6661871d..3ab57d65f 100644
--- a/pdns/dnssecinfra.cc
+++ b/pdns/dnssecinfra.cc
@@ -234,7 +234,7 @@ DNSKEYRecordContent getDNSKEYFor(const std::string& keyRepositoryDir, const std:
   }
 }
 
-
+// XXXX FIXME THINK ABOUT LOCKING HERE
 map<pair<string, uint16_t>, RRSIGRecordContent> g_rrsigs;
 
 void fillOutRRSIG(const std::string& keyrepodir, const std::string& signQName, RRSIGRecordContent& rrc, const std::string& hash, vector<shared_ptr<DNSRecordContent> >& toSign, bool withKSK) 
@@ -246,7 +246,7 @@ void fillOutRRSIG(const std::string& keyrepodir, const std::string& signQName, R
   rrc.d_algorithm = drc.d_algorithm;
   
   if(g_rrsigs.count(make_pair(hash, rrc.d_tag))) {
-    cerr<<"RRSIG cache hit !"<<endl;
+    // cerr<<"RRSIG cache hit !"<<endl;
     rrc = g_rrsigs[make_pair(hash, rrc.d_tag)];
     return;
   }
@@ -303,7 +303,7 @@ int getRRSIGForRRSET(const std::string& keyrepodir, const std::string signQName,
 
 void addSignature(const std::string& keyrepodir, const std::string signQName, const std::string& wildcardname, uint16_t signQType, uint32_t signTTL, DNSPacketWriter::Place signPlace, vector<shared_ptr<DNSRecordContent> >& toSign, DNSPacketWriter& pw)
 {
-  cerr<<"Asked to sign '"<<signQName<<"'|"<<DNSRecordContent::NumberToType(signQType)<<", "<<toSign.size()<<" records\n";
+  // cerr<<"Asked to sign '"<<signQName<<"'|"<<DNSRecordContent::NumberToType(signQType)<<", "<<toSign.size()<<" records\n";
 
   RRSIGRecordContent rrc;
   if(toSign.empty())
@@ -334,7 +334,7 @@ std::string hashQNameWithSalt(unsigned int times, const std::string& salt, const
   toHash.assign(simpleCompress(toLower(qname)));
   toHash.append(salt);
 
-  cerr<<makeHexDump(toHash)<<endl;
+//  cerr<<makeHexDump(toHash)<<endl;
   unsigned char hash[20];
   for(;;) {
     sha1((unsigned char*)toHash.c_str(), toHash.length(), hash);