From: Christoph M. Becker <cmbecker69@gmx.de>
Date: Tue, 3 Sep 2019 11:11:08 +0000 (+0200)
Subject: Don't explicitly set return value on ZPP failure in ext/xml
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=37713c80e49b37833dfd48a7f880fa9516ee0dd2;p=php

Don't explicitly set return value on ZPP failure in ext/xml

Failing ZPP throws as of PHP 8.0.0, so explicitly setting a return
value is useless, and also slightly confusing.
---

diff --git a/ext/xml/xml.c b/ext/xml/xml.c
index d6e91b69ce..4da8f54c5c 100644
--- a/ext/xml/xml.c
+++ b/ext/xml/xml.c
@@ -1065,7 +1065,7 @@ static void php_xml_parser_create_impl(INTERNAL_FUNCTION_PARAMETERS, int ns_supp
 	XML_Char *encoding;
 
 	if (zend_parse_parameters(ZEND_NUM_ARGS(), (ns_support ? "|ss": "|s"), &encoding_param, &encoding_param_len, &ns_param, &ns_param_len) == FAILURE) {
-		RETURN_FALSE;
+		return;
 	}
 
 	if (encoding_param != NULL) {