From: Andrew Dunstan <andrew@dunslane.net>
Date: Wed, 16 Jun 2010 14:50:34 +0000 (+0000)
Subject: Remove perl symbol table additions for plperl functions, and mention of it
X-Git-Tag: REL9_0_BETA3~98
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=3659c62350c9f362007b21c5cc1677c401cc3a33;p=postgresql

Remove perl symbol table additions for plperl functions, and mention of it
in the release notes, as it is not apparently providing anything useful.
---

diff --git a/doc/src/sgml/release-9.0.sgml b/doc/src/sgml/release-9.0.sgml
index d3fabaf83e..3f3c966894 100644
--- a/doc/src/sgml/release-9.0.sgml
+++ b/doc/src/sgml/release-9.0.sgml
@@ -1,4 +1,4 @@
-<!-- $PostgreSQL: pgsql/doc/src/sgml/release-9.0.sgml,v 2.31 2010/06/14 02:18:43 rhaas Exp $ -->
+<!-- $PostgreSQL: pgsql/doc/src/sgml/release-9.0.sgml,v 2.32 2010/06/16 14:50:34 adunstan Exp $ -->
 
  <sect1 id="release-9-0">
   <title>Release 9.0</title>
@@ -1759,18 +1759,6 @@
       </para>
      </listitem>
 
-     <listitem>
-      <para>
-       PL/Perl subroutines are now given perl-visible names (Tim Bunce)
-      </para>
-
-      <para>
-       PL/Perl subroutines are anonymous subrefs; this change adds entries 
-       to the Perl symbol table for them, making profiling and code coverage 
-       tools much more usable.
-      </para>
-     </listitem>
-
     </itemizedlist>
 
    </sect4>
diff --git a/src/pl/plperl/plperl.c b/src/pl/plperl/plperl.c
index 7c65454883..b22801b851 100644
--- a/src/pl/plperl/plperl.c
+++ b/src/pl/plperl/plperl.c
@@ -1,7 +1,7 @@
 /**********************************************************************
  * plperl.c - perl as a procedural language for PostgreSQL
  *
- *	  $PostgreSQL: pgsql/src/pl/plperl/plperl.c,v 1.176 2010/05/17 19:43:04 adunstan Exp $
+ *	  $PostgreSQL: pgsql/src/pl/plperl/plperl.c,v 1.177 2010/06/16 14:50:34 adunstan Exp $
  *
  **********************************************************************/
 
@@ -1319,10 +1319,6 @@ plperl_create_sub(plperl_proc_desc *prodesc, char *s, Oid fn_oid)
 				(errmsg("didn't get a CODE ref from compiling %s",
 						prodesc->proname)));
 	
-	/* give the subroutine a proper name in the main:: symbol table */
-	CvGV(SvRV(subref)) = (GV *) newSV(0);
-	gv_init(CvGV(SvRV(subref)), PL_defstash, subname, strlen(subname), TRUE);
-	
 	prodesc->reference = subref;
 	
 	return;