From: Chris Lattner Date: Tue, 13 Apr 2010 17:34:23 +0000 (+0000) Subject: Teach HasSideEffect about InitListExprs. Not having X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=363ff23cfddb51abe4ee4212a6dd3c9b534fcc8b;p=clang Teach HasSideEffect about InitListExprs. Not having this caused us to codegen dead globals like this: struct foo { int a; int b; }; static struct foo fooarray[] = { {1, 2}, {4}, }; git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@101150 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/AST/ExprConstant.cpp b/lib/AST/ExprConstant.cpp index eeeeb5c836..c9aff6408f 100644 --- a/lib/AST/ExprConstant.cpp +++ b/lib/AST/ExprConstant.cpp @@ -203,6 +203,13 @@ public: return Visit(E->getSubExpr()); } bool VisitUnaryOperator(UnaryOperator *E) { return Visit(E->getSubExpr()); } + + // Has side effects if any element does. + bool VisitInitListExpr(InitListExpr *E) { + for (unsigned i = 0, e = E->getNumInits(); i != e; ++i) + if (Visit(E->getInit(i))) return true; + return false; + } }; } // end anonymous namespace