From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Sat, 23 Jan 2016 23:12:54 +0000 (-0500)
Subject: Still further adjust degree-based trig functions for more portability.
X-Git-Tag: REL9_6_BETA1~823
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=360f67d31a5656991122b89c9ca22a860f41512c;p=postgresql

Still further adjust degree-based trig functions for more portability.

Indeed, the non-static declaration foreseen in my previous commit message
is necessary.  Per Noah Misch.
---

diff --git a/src/backend/utils/adt/float.c b/src/backend/utils/adt/float.c
index 099736e519..788c17033f 100644
--- a/src/backend/utils/adt/float.c
+++ b/src/backend/utils/adt/float.c
@@ -83,6 +83,10 @@ static int	float8_cmp_internal(float8 a, float8 b);
 static double sind_q1(double x);
 static double cosd_q1(double x);
 
+/* This is INTENTIONALLY NOT STATIC.  Don't "fix" it. */
+void init_degree_constants(float8 thirty, float8 forty_five, float8 sixty,
+					  float8 one_half, float8 one);
+
 #ifndef HAVE_CBRT
 /*
  * Some machines (in particular, some versions of AIX) have an extern
@@ -1771,11 +1775,16 @@ dtan(PG_FUNCTION_ARGS)
  * want exact results, we must ensure that none of the scaling constants used
  * in the degree-based trig functions are computed that way.
  *
+ * The whole approach fails if init_degree_constants() gets inlined into the
+ * call sites, since then constant-folding can happen anyway.  Currently it
+ * seems sufficient to declare it non-static to prevent that.  We have no
+ * expectation that other files will call this, but don't tell gcc that.
+ *
  * Other hazards we are trying to forestall with this kluge include the
  * possibility that compilers will rearrange the expressions, or compute
  * some intermediate results in registers wider than a standard double.
  */
-static void
+void
 init_degree_constants(float8 thirty, float8 forty_five, float8 sixty,
 					  float8 one_half, float8 one)
 {