From: Fangrui Song Date: Fri, 5 Apr 2019 16:16:23 +0000 (+0000) Subject: Change some dyn_cast to more apropriate isa. NFC X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=360e56327d17ae3f0d147f7d299d094a4af4b058;p=llvm Change some dyn_cast to more apropriate isa. NFC git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@357773 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/CodeGen/AsmPrinter/AsmPrinter.cpp b/lib/CodeGen/AsmPrinter/AsmPrinter.cpp index 7887ce17550..fe22e946c16 100644 --- a/lib/CodeGen/AsmPrinter/AsmPrinter.cpp +++ b/lib/CodeGen/AsmPrinter/AsmPrinter.cpp @@ -1231,7 +1231,7 @@ static bool isGOTEquivalentCandidate(const GlobalVariable *GV, // GlobalVariable or Function, i.e., as GlobalValue. if (!GV->hasGlobalUnnamedAddr() || !GV->hasInitializer() || !GV->isConstant() || !GV->isDiscardableIfUnused() || - !dyn_cast(GV->getOperand(0))) + !isa(GV->getOperand(0))) return false; // To be a got equivalent, at least one of its users need to be a constant diff --git a/lib/CodeGen/StackProtector.cpp b/lib/CodeGen/StackProtector.cpp index 34942bc1b6c..dc215a033fc 100644 --- a/lib/CodeGen/StackProtector.cpp +++ b/lib/CodeGen/StackProtector.cpp @@ -514,7 +514,7 @@ BasicBlock *StackProtector::CreateFailBB() { } bool StackProtector::shouldEmitSDCheck(const BasicBlock &BB) const { - return HasPrologue && !HasIRCheck && dyn_cast(BB.getTerminator()); + return HasPrologue && !HasIRCheck && isa(BB.getTerminator()); } void StackProtector::copyToMachineFrameInfo(MachineFrameInfo &MFI) const { diff --git a/lib/Target/BPF/AsmParser/BPFAsmParser.cpp b/lib/Target/BPF/AsmParser/BPFAsmParser.cpp index 6d2183f6f39..6fcf34370a6 100644 --- a/lib/Target/BPF/AsmParser/BPFAsmParser.cpp +++ b/lib/Target/BPF/AsmParser/BPFAsmParser.cpp @@ -125,7 +125,7 @@ public: bool isMem() const override { return false; } bool isConstantImm() const { - return isImm() && dyn_cast(getImm()); + return isImm() && isa(getImm()); } int64_t getConstantImm() const { diff --git a/lib/Target/Hexagon/HexagonPatterns.td b/lib/Target/Hexagon/HexagonPatterns.td index 9a7fda37cd4..fb731f56bfb 100644 --- a/lib/Target/Hexagon/HexagonPatterns.td +++ b/lib/Target/Hexagon/HexagonPatterns.td @@ -278,7 +278,7 @@ class Su_ni1 if (hasOneUse(N)){ // Check if Op1 is an immediate operand. SDValue Op1 = N->getOperand(1); - return !dyn_cast(Op1); + return !isa(Op1); } return false;}], Op.OperandTransform>; diff --git a/lib/Target/X86/X86ISelDAGToDAG.cpp b/lib/Target/X86/X86ISelDAGToDAG.cpp index 3a9ef4189ff..f16d7e15c1a 100644 --- a/lib/Target/X86/X86ISelDAGToDAG.cpp +++ b/lib/Target/X86/X86ISelDAGToDAG.cpp @@ -2129,7 +2129,7 @@ bool X86DAGToDAGISel::selectLEA64_32Addr(SDValue N, SDValue &Base, RegisterSDNode *RN = dyn_cast(Base); if (RN && RN->getReg() == 0) Base = CurDAG->getRegister(0, MVT::i64); - else if (Base.getValueType() == MVT::i32 && !dyn_cast(Base)) { + else if (Base.getValueType() == MVT::i32 && !isa(Base)) { // Base could already be %rip, particularly in the x32 ABI. SDValue ImplDef = SDValue(CurDAG->getMachineNode(X86::IMPLICIT_DEF, DL, MVT::i64), 0); diff --git a/lib/Transforms/IPO/SampleProfile.cpp b/lib/Transforms/IPO/SampleProfile.cpp index b6ea014e79f..2955c338e91 100644 --- a/lib/Transforms/IPO/SampleProfile.cpp +++ b/lib/Transforms/IPO/SampleProfile.cpp @@ -1329,7 +1329,7 @@ void SampleProfileLoader::propagateWeights(Function &F) { annotateValueSite(*I.getParent()->getParent()->getParent(), I, SortedCallTargets, Sum, IPVK_IndirectCallTarget, SortedCallTargets.size()); - } else if (!dyn_cast(&I)) { + } else if (!isa(&I)) { I.setMetadata(LLVMContext::MD_prof, MDB.createBranchWeights( {static_cast(BlockWeights[BB])})); diff --git a/lib/Transforms/Instrumentation/IndirectCallPromotion.cpp b/lib/Transforms/Instrumentation/IndirectCallPromotion.cpp index 7c9e2ad50c7..c7371f567ff 100644 --- a/lib/Transforms/Instrumentation/IndirectCallPromotion.cpp +++ b/lib/Transforms/Instrumentation/IndirectCallPromotion.cpp @@ -238,7 +238,7 @@ ICallPromotionFunc::getPromotionCandidatesForCallSite( LLVM_DEBUG(dbgs() << " Candidate " << I << " Count=" << Count << " Target_func: " << Target << "\n"); - if (ICPInvokeOnly && dyn_cast(Inst)) { + if (ICPInvokeOnly && isa(Inst)) { LLVM_DEBUG(dbgs() << " Not promote: User options.\n"); ORE.emit([&]() { return OptimizationRemarkMissed(DEBUG_TYPE, "UserOptions", Inst) @@ -246,7 +246,7 @@ ICallPromotionFunc::getPromotionCandidatesForCallSite( }); break; } - if (ICPCallOnly && dyn_cast(Inst)) { + if (ICPCallOnly && isa(Inst)) { LLVM_DEBUG(dbgs() << " Not promote: User option.\n"); ORE.emit([&]() { return OptimizationRemarkMissed(DEBUG_TYPE, "UserOptions", Inst) diff --git a/lib/Transforms/Instrumentation/PGOInstrumentation.cpp b/lib/Transforms/Instrumentation/PGOInstrumentation.cpp index ac97f7fb9b2..99377b8a6cd 100644 --- a/lib/Transforms/Instrumentation/PGOInstrumentation.cpp +++ b/lib/Transforms/Instrumentation/PGOInstrumentation.cpp @@ -1369,7 +1369,7 @@ void MemIntrinsicVisitor::instrumentOneMemIntrinsic(MemIntrinsic &MI) { Type *Int64Ty = Builder.getInt64Ty(); Type *I8PtrTy = Builder.getInt8PtrTy(); Value *Length = MI.getLength(); - assert(!dyn_cast(Length)); + assert(!isa(Length)); Builder.CreateCall( Intrinsic::getDeclaration(M, Intrinsic::instrprof_value_profile), {ConstantExpr::getBitCast(FuncNameVar, I8PtrTy), diff --git a/lib/Transforms/Utils/CodeExtractor.cpp b/lib/Transforms/Utils/CodeExtractor.cpp index 4db895feaa3..d3bcfd56841 100644 --- a/lib/Transforms/Utils/CodeExtractor.cpp +++ b/lib/Transforms/Utils/CodeExtractor.cpp @@ -329,7 +329,7 @@ bool CodeExtractor::isLegalToShrinkwrapLifetimeMarkers( if (dyn_cast(MemAddr)) break; Value *Base = MemAddr->stripInBoundsConstantOffsets(); - if (!dyn_cast(Base) || Base == AI) + if (!isa(Base) || Base == AI) return false; break; } diff --git a/lib/Transforms/Utils/FunctionImportUtils.cpp b/lib/Transforms/Utils/FunctionImportUtils.cpp index e48fcbdeff4..8e80ee2c549 100644 --- a/lib/Transforms/Utils/FunctionImportUtils.cpp +++ b/lib/Transforms/Utils/FunctionImportUtils.cpp @@ -129,7 +129,7 @@ FunctionImportGlobalProcessing::getLinkage(const GlobalValue *SGV, // definitions upon import, so that they are available for inlining // and/or optimization, but are turned into declarations later // during the EliminateAvailableExternally pass. - if (doImportAsDefinition(SGV) && !dyn_cast(SGV)) + if (doImportAsDefinition(SGV) && !isa(SGV)) return GlobalValue::AvailableExternallyLinkage; // An imported external declaration stays external. return SGV->getLinkage(); @@ -158,7 +158,7 @@ FunctionImportGlobalProcessing::getLinkage(const GlobalValue *SGV, // equivalent, so the issue described above for weak_any does not exist, // and the definition can be imported. It can be treated similarly // to an imported externally visible global value. - if (doImportAsDefinition(SGV) && !dyn_cast(SGV)) + if (doImportAsDefinition(SGV) && !isa(SGV)) return GlobalValue::AvailableExternallyLinkage; else return GlobalValue::ExternalLinkage; @@ -176,7 +176,7 @@ FunctionImportGlobalProcessing::getLinkage(const GlobalValue *SGV, // If we are promoting the local to global scope, it is handled // similarly to a normal externally visible global. if (DoPromote) { - if (doImportAsDefinition(SGV) && !dyn_cast(SGV)) + if (doImportAsDefinition(SGV) && !isa(SGV)) return GlobalValue::AvailableExternallyLinkage; else return GlobalValue::ExternalLinkage;