From: Paul Ramsey <pramsey@cleverelephant.ca>
Date: Wed, 13 Sep 2017 17:22:03 +0000 (+0000)
Subject: Fix comments up on cmp() func
X-Git-Tag: 2.4.0rc2~64
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=35d71368fadccad813ab6d2b343b1759b50f90cd;p=postgis

Fix comments up on cmp() func


git-svn-id: http://svn.osgeo.org/postgis/trunk@15711 b70326c6-7e19-0410-871a-916f4a2858ee
---

diff --git a/liblwgeom/g_serialized.c b/liblwgeom/g_serialized.c
index 84d16b78c..69882aadd 100644
--- a/liblwgeom/g_serialized.c
+++ b/liblwgeom/g_serialized.c
@@ -317,7 +317,9 @@ int gserialized_cmp(const GSERIALIZED *g1, const GSERIALIZED *g2)
 	if ( bsz1 == bsz2 && srid1 == srid2 && cmp == 0 )
 		return 0;
 	
-	/* using the centroids, and preferring the X axis */
+	/* Using the centroids, calculate somewhat sortable */
+    /* hash key. The key doesn't provide good locality over */
+    /* the +/- boundary, but otherwise is pretty OK */
 	hash1 = gbox_get_sortable_hash(&box1);
 	hash2 = gbox_get_sortable_hash(&box2);
 
@@ -349,13 +351,13 @@ int gserialized_cmp(const GSERIALIZED *g1, const GSERIALIZED *g2)
 	else if (box1.ymax > box2.ymax)
 		return 1;
 
-	/* How about object size? Sort on that... */
+	/* Geeze! How about object size? Sort on that... */
 	if (hsz1 < hsz2)
 		return -1;
 	else if (hsz1 > hsz2)
 		return 1;
 	
-	/* Well, they aren't memcmp equal, so we'll sort on the memcmp */
+	/* OK fine, we'll sort on the memcmp just to be done with this */
 	return cmp == 0 ? 0 : (cmp > 0 ? 1 : -1);
 }