From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Mon, 15 Nov 2010 06:00:48 +0000 (-0500)
Subject: Adjust comments about what's needed to avoid make 3.80 bug.
X-Git-Tag: REL9_1_ALPHA3~178
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=357edc9a9952582c510cff1b08ebc5fd8df81a3b;p=postgresql

Adjust comments about what's needed to avoid make 3.80 bug.

... based on further tracing through that code.
---

diff --git a/src/Makefile.global.in b/src/Makefile.global.in
index cb5f31c3ea..85cf617786 100644
--- a/src/Makefile.global.in
+++ b/src/Makefile.global.in
@@ -559,9 +559,10 @@ endif
 # This function is only for internal use below.  It should be called
 # using $(eval).  It will set up a target so that it recurses into
 # a given subdirectory.  Note that to avoid a nasty bug in make 3.80,
-# it is important that the expansion of this function not exceed about
-# 200 bytes.  This is why we make it apply to just one subdirectory at a
-# time, rather than to a list of subdirectories.
+# this function has to avoid using any complicated constructs (like
+# multiple targets on a line) and also not contain any lines that expand
+# to more than about 200 bytes.  This is why we make it apply to just one
+# subdirectory at a time, rather than to a list of subdirectories.
 # $1: target name, e.g., all
 # $2: subdir name
 # $3: target to run in subdir, usually same as $1