From: Alexander Barton <alex@barton.de>
Date: Thu, 3 Feb 2005 09:27:09 +0000 (+0000)
Subject: Fixed a bug that could case a root exploit when the daemon is compiled
X-Git-Tag: rel-0-8-3~1
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=35631475145f0acc55df7f3702715442d0c7fae2;p=ngircd

Fixed a bug that could case a root exploit when the daemon is compiled
to do IDENT lookups and is logging to syslog. Bug discovered by CoKi,
<coki@nosystem.com.ar>, thanks a lot! [from HEAD.]
(http://www.nosystem.com.ar/advisories/advisory-11.txt)
---

diff --git a/ChangeLog b/ChangeLog
index 9f6daf92..379a4e00 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -10,6 +10,13 @@
                                -- ChangeLog --
 
 
+ngIRCd 0.8.x
+
+  - Fixed a bug that could case a root exploit when the daemon is compiled
+    to do IDENT lookups and is logging to syslog. Bug discovered by CoKi,
+    <coki@nosystem.com.ar>, thanks a lot!
+    (http://www.nosystem.com.ar/advisories/advisory-11.txt)
+
 ngIRCd 0.8.2 (2005-01-26)
 
   - Added doc/SSL.txt to distribution.
@@ -554,4 +561,4 @@ ngIRCd 0.0.1, 31.12.2001
 
 
 -- 
-$Id: ChangeLog,v 1.233.2.18 2005/02/03 09:20:58 alex Exp $
+$Id: ChangeLog,v 1.233.2.19 2005/02/03 09:27:09 alex Exp $
diff --git a/src/ngircd/log.c b/src/ngircd/log.c
index 794ff0ac..dd7611e4 100644
--- a/src/ngircd/log.c
+++ b/src/ngircd/log.c
@@ -14,7 +14,7 @@
 
 #include "portab.h"
 
-static char UNUSED id[] = "$Id: log.c,v 1.44.2.3 2004/06/26 09:06:27 alex Exp $";
+static char UNUSED id[] = "$Id: log.c,v 1.44.2.4 2005/02/03 09:27:09 alex Exp $";
 
 #include "imp.h"
 #include <assert.h>
@@ -269,7 +269,7 @@ va_dcl
 		fflush( stdout );
 	}
 #ifdef SYSLOG
-	else syslog( Level, msg );
+	else syslog( Level, "%s", msg );
 #endif
 } /* Log_Resolver */