From: Todd C. Miller <Todd.Miller@courtesan.com>
Date: Tue, 28 Feb 2012 19:16:39 +0000 (-0500)
Subject: Check the owner and mode in -c (check) mode unless the -f option
X-Git-Tag: SUDO_1_8_5~1^2~182
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=35280a84379dbb434ab3c7ccdd3a0719b9fc73ce;p=sudo

Check the owner and mode in -c (check) mode unless the -f option
is specified.  Previously, the owner and mode were checked on the
main sudoers file when the -s (strict) option was given, but this
was not documented.
---

diff --git a/doc/visudo.pod b/doc/visudo.pod
index 27cb2eb7e..c3e9ba74b 100644
--- a/doc/visudo.pod
+++ b/doc/visudo.pod
@@ -70,10 +70,10 @@ B<visudo> accepts the following command line options:
 =item -c
 
 Enable B<check-only> mode.  The existing I<sudoers> file will be
-checked for syntax and a message will be printed to the
-standard output detailing the status of I<sudoers>.
-If the syntax check completes successfully, B<visudo> will
-exit with a value of 0.  If a syntax error is encountered,
+checked for syntax errors, owner and mode.  A message will be printed
+to the standard output describing the status of I<sudoers> unless
+the B<-q> option was specified.  If the check completes successfully,
+B<visudo> will exit with a value of 0.  If an error is encountered,
 B<visudo> will exit with a value of 1.
 
 =item -f I<sudoers>
diff --git a/plugins/sudoers/visudo.c b/plugins/sudoers/visudo.c
index 2a45e5f73..72cd5bfd9 100644
--- a/plugins/sudoers/visudo.c
+++ b/plugins/sudoers/visudo.c
@@ -105,7 +105,7 @@ static char *get_editor(char **);
 static void get_hostname(void);
 static int whatnow(void);
 static int check_aliases(bool, bool);
-static bool check_syntax(char *, bool, bool);
+static bool check_syntax(char *, bool, bool, bool);
 static bool edit_sudoers(struct sudoersfile *, char *, char *, int);
 static bool install_sudoers(struct sudoersfile *, bool);
 static int print_unused(void *, void *);
@@ -225,7 +225,7 @@ main(int argc, char *argv[])
     init_defaults();
 
     if (checkonly) {
-	exitcode = check_syntax(sudoers_path, quiet, strict) ? 0 : 1;
+	exitcode = check_syntax(sudoers_path, quiet, strict, oldperms) ? 0 : 1;
 	goto done;
     }
 
@@ -776,9 +776,35 @@ run_command(char *path, char **argv)
 }
 
 static bool
-check_syntax(char *sudoers_path, bool quiet, bool strict)
+check_owner(const char *path, bool quiet)
 {
     struct stat sb;
+    bool ok = true;
+    debug_decl(check_owner, SUDO_DEBUG_UTIL)
+
+    if (stat(path, &sb) == 0) {
+	if (sb.st_uid != SUDOERS_UID || sb.st_gid != SUDOERS_GID) {
+	    ok = false;
+	    if (!quiet) {
+		fprintf(stderr,
+		    _("%s: wrong owner (uid, gid) should be (%u, %u)\n"),
+		    path, SUDOERS_UID, SUDOERS_GID);
+		}
+	}
+	if ((sb.st_mode & 07777) != SUDOERS_MODE) {
+	    ok = false;
+	    if (!quiet) {
+		fprintf(stderr, _("%s: bad permissions, should be mode 0%o\n"),
+		    path, SUDOERS_MODE);
+	    }
+	}
+    }
+    debug_return_bool(ok);
+}
+
+static bool
+check_syntax(char *sudoers_path, bool quiet, bool strict, bool oldperms)
+{
     bool ok = false;
     debug_decl(check_syntax, SUDO_DEBUG_UTIL)
 
@@ -802,37 +828,28 @@ check_syntax(char *sudoers_path, bool quiet, bool strict)
 	errorfile = sudoers_path;
     }
     ok = !parse_error;
-    if (!quiet) {
-	if (parse_error) {
+
+    if (parse_error) {
+	if (!quiet) {
 	    if (errorlineno != -1)
 		(void) printf(_("parse error in %s near line %d\n"),
 		    errorfile, errorlineno);
 	    else
 		(void) printf(_("parse error in %s\n"), errorfile);
-	} else {
-	    struct sudoersfile *sp;
-	    (void) printf(_("%s: parsed OK\n"), sudoers_path);
-	    tq_foreach_fwd(&sudoerslist, sp) {
-		(void) printf(_("%s: parsed OK\n"), sp->path);
-	    }
 	}
-    }
-    /* Check mode and owner in strict mode. */
-    if (strict && yyin != stdin && fstat(fileno(yyin), &sb) == 0) {
-	if (sb.st_uid != SUDOERS_UID || sb.st_gid != SUDOERS_GID) {
-	    ok = false;
-	    if (!quiet) {
-		fprintf(stderr,
-		    _("%s: wrong owner (uid, gid) should be (%u, %u)\n"),
-		    sudoers_path, SUDOERS_UID, SUDOERS_GID);
-		}
-	}
-	if ((sb.st_mode & 07777) != SUDOERS_MODE) {
+    } else {
+	struct sudoersfile *sp;
+
+	/* Parsed OK, check mode and owner. */
+	if (oldperms || check_owner(sudoers_path, quiet))
+	    (void) printf(_("%s: parsed OK\n"), sudoers_path);
+	else
 	    ok = false;
-	    if (!quiet) {
-		fprintf(stderr, _("%s: bad permissions, should be mode 0%o\n"),
-		    sudoers_path, SUDOERS_MODE);
-	    }
+	tq_foreach_fwd(&sudoerslist, sp) {
+	    if (oldperms || check_owner(sp->path, quiet))
+		(void) printf(_("%s: parsed OK\n"), sp->path);
+	    else
+		ok = false;
 	}
     }