From: Richard Russon <rich@flatcap.org>
Date: Fri, 30 Mar 2018 12:32:26 +0000 (+0100)
Subject: tidy mutt_str_strdup
X-Git-Tag: neomutt-20180512~70^2~1
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=34f3ca67db9fe3947a119215c098ab5108a466ea;p=neomutt

tidy mutt_str_strdup
---

diff --git a/mutt/string.c b/mutt/string.c
index e2580eb53..e2bccd2e0 100644
--- a/mutt/string.c
+++ b/mutt/string.c
@@ -276,21 +276,19 @@ int mutt_str_atoul(const char *str, unsigned long *dst)
 
 /**
  * mutt_str_strdup - Copy a string, safely
- * @param s String to copy
+ * @param str String to copy
  * @retval ptr  Copy of the string
  * @retval NULL if s was NULL
  */
-char *mutt_str_strdup(const char *s)
+char *mutt_str_strdup(const char *str)
 {
-  char *p = NULL;
-  size_t l;
+  if (!str || !*str)
+    return NULL;
 
-  if (!s || !*s)
-    return 0;
-  l = strlen(s) + 1;
-  p = mutt_mem_malloc(l);
-  memcpy(p, s, l);
-  return p;
+  const size_t len = strlen(str) + 1;
+  char *copy = mutt_mem_malloc(len);
+  memcpy(copy, str, len);
+  return copy;
 }
 
 /**
diff --git a/mutt/string2.h b/mutt/string2.h
index 4f4c4c2ad..ae1d17aa0 100644
--- a/mutt/string2.h
+++ b/mutt/string2.h
@@ -87,7 +87,7 @@ char *      mutt_str_strcat(char *d, size_t l, const char *s);
 const char *mutt_str_strchrnul(const char *s, char c);
 int         mutt_str_strcmp(const char *a, const char *b);
 int         mutt_str_strcoll(const char *a, const char *b);
-char *      mutt_str_strdup(const char *s);
+char *      mutt_str_strdup(const char *str);
 size_t      mutt_str_strfcpy(char *dest, const char *src, size_t dsize);
 const char *mutt_str_stristr(const char *haystack, const char *needle);
 size_t      mutt_str_strlen(const char *a);