From: Chris Hofstaedtler <chris.hofstaedtler@deduktiva.com>
Date: Fri, 5 Jan 2018 17:40:02 +0000 (+0100)
Subject: Improve DNSUPDATE prereq check log messages
X-Git-Tag: dnsdist-1.3.0~123^2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=34efd34d9c17641b294a98a0ab96765e441fcc24;p=pdns

Improve DNSUPDATE prereq check log messages
---

diff --git a/pdns/rfc2136handler.cc b/pdns/rfc2136handler.cc
index b4d0ab963..9dec9cfdd 100644
--- a/pdns/rfc2136handler.cc
+++ b/pdns/rfc2136handler.cc
@@ -833,7 +833,7 @@ int PacketHandler::processUpdate(DNSPacket *p) {
     if (rr->d_place == DNSResourceRecord::ANSWER) {
       int res = checkUpdatePrerequisites(rr, &di);
       if (res>0) {
-        L<<Logger::Error<<msgPrefix<<"Failed PreRequisites check, returning "<<res<<endl;
+        L<<Logger::Error<<msgPrefix<<"Failed PreRequisites check, returning "<<RCode::to_s(res)<<endl;
         di.backend->abortTransaction();
         return res;
       }
@@ -880,7 +880,7 @@ int PacketHandler::processUpdate(DNSPacket *p) {
         }
       }
       if (matchRR != foundRR || foundRR != vec->size()) {
-        L<<Logger::Error<<msgPrefix<<"Failed PreRequisites check, returning NXRRSet"<<endl;
+        L<<Logger::Error<<msgPrefix<<"Failed PreRequisites check (RRs differ), returning NXRRSet"<<endl;
         di.backend->abortTransaction();
         return RCode::NXRRSet;
       }