From: Markus Lavin Date: Thu, 9 May 2019 08:29:04 +0000 (+0000) Subject: Make sub-registers index names case sensitive in the MIRParser X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=34a05f9ca4df871839ab70ddc04c446f22d84684;p=llvm Make sub-registers index names case sensitive in the MIRParser Prior to this change sub-register index names are assumed to be lower case (but they are printed with original casing). This means that if a target has some upper case characters in its sub-register names then mir-export directly followed by mir-import is not possible. This also means that sub-register indices currently are (and will continue to be) slightly inconsistent with register names which are printed and assumed to be lower case. As the current textual representation of mir has a few inconsistencies in this area it is a bit arbitrary how to address the matter. This change is towards the direction that we feel is most correct (i.e. case sensitivity). Differential Revision: https://reviews.llvm.org/D61499 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@360318 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/CodeGen/MIRParser/MIParser.cpp b/lib/CodeGen/MIRParser/MIParser.cpp index d414b6a0b4b..92b238f75ff 100644 --- a/lib/CodeGen/MIRParser/MIParser.cpp +++ b/lib/CodeGen/MIRParser/MIParser.cpp @@ -176,7 +176,7 @@ void PerTargetMIParsingState::initNames2SubRegIndices() { const TargetRegisterInfo *TRI = Subtarget.getRegisterInfo(); for (unsigned I = 1, E = TRI->getNumSubRegIndices(); I < E; ++I) Names2SubRegIndices.insert( - std::make_pair(StringRef(TRI->getSubRegIndexName(I)).lower(), I)); + std::make_pair(TRI->getSubRegIndexName(I), I)); } unsigned PerTargetMIParsingState::getSubRegIndex(StringRef Name) {