From: Xinchen Hui <laruence@php.net>
Date: Thu, 17 Nov 2011 02:22:06 +0000 (+0000)
Subject: improve the test,  let it say about errors
X-Git-Tag: php-5.4.0RC2~60
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=347876158c182cb05c84845ddb00481f7a634ac3;p=php

improve the test,  let it say about errors
---

diff --git a/sapi/cli/tests/php_cli_server.inc b/sapi/cli/tests/php_cli_server.inc
index ab754eb408..4a8170955b 100644
--- a/sapi/cli/tests/php_cli_server.inc
+++ b/sapi/cli/tests/php_cli_server.inc
@@ -12,7 +12,7 @@ function php_cli_server_start($code = 'echo "Hello world";', $no_router = FALSE)
 	$descriptorspec = array(
 		0 => STDIN,
 		1 => STDOUT,
-		2 => STDERR,
+		2 => array("pipe", "w"),
 	);
 
 	if (substr(PHP_OS, 0, 3) == 'WIN') {
@@ -21,25 +21,35 @@ function php_cli_server_start($code = 'echo "Hello world";', $no_router = FALSE)
 			$cmd .= " {$router}";
 		}
 
-		$handle = proc_open(addslashes($cmd), $descriptorspec, $pipes, $doc_root, NULL, array("bypass_shell" => true,  "suppress_errors" => true));
+		$handle = proc_open(addslashes($cmd), $descriptorspec, $pipes, $doc_root, NULL, array("bypass_shell" => true));
 	} else {
 		$cmd = "exec {$php_executable} -t {$doc_root} -S " . PHP_CLI_SERVER_ADDRESS;
 		if (!$no_router) {
 			$cmd .= " {$router}";
 		}
-		$cmd .= " 2>/dev/null";
 
 		$handle = proc_open($cmd, $descriptorspec, $pipes, $doc_root);
 	}
 
+	//@FIXME is there a better way to make sure the process is ready?
+	usleep(50000);
+
+	stream_set_blocking($pipes[2], 0);
+	if ($err = stream_get_contents($pipes[2])) {
+		fclose($pipes[2]);
+		proc_terminate($handle);
+		@unlink(__DIR__ . "/{$router}");
+		die("Cli sever could not be started: " . $err);
+	}
+
 	register_shutdown_function(
-		function($handle) use($router) {
+		function($handle, $router, $pipes) {
+			stream_get_contents($pipes[2]);
+			fclose($pipes[2]);
 			proc_terminate($handle);
 			@unlink(__DIR__ . "/{$router}");
 		},
-			$handle
+			$handle, $router, $pipes
 		);
-	usleep(50000);
 }
 ?>
-