From: Giampaolo Rodolà Date: Wed, 12 May 2010 00:33:15 +0000 (+0000) Subject: Merged revisions 81102 via svnmerge from X-Git-Tag: v3.2a1~828 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=340d7d2cc3ea0abc9794fe3e8ba46f87bd3339f7;p=python Merged revisions 81102 via svnmerge from svn+ssh://pythondev@svn.python.org/python/trunk ........ r81102 | giampaolo.rodola | 2010-05-12 02:29:27 +0200 (mer, 12 mag 2010) | 1 line Removed the assertion that dispatcher.connected attribute must be False after a single connect() call. Solaris and FreeBSD buildbots failures showed how connect() can succeed even in a single call. All bo failures should definitively be fixed now. ........ --- diff --git a/Lib/test/test_asyncore.py b/Lib/test/test_asyncore.py index e5b2f0cfc8..b2c0198da7 100644 --- a/Lib/test/test_asyncore.py +++ b/Lib/test/test_asyncore.py @@ -619,12 +619,8 @@ class BaseTestAPI(unittest.TestCase): # we start disconnected self.assertFalse(server.connected) self.assertTrue(server.accepting) - # XXX - Solaris seems to connect() immediately even without - # starting the poller. This is something which should be - # fixed as handle_connect() gets called immediately even if - # no connection actually took place (see issue #8490). - if not sys.platform.startswith("sunos"): - self.assertFalse(client.connected) + # this can't be taken for granted across all platforms + #self.assertFalse(client.connected) self.assertFalse(client.accepting) # execute some loops so that client connects to server