From: Haicheng Wu Date: Fri, 25 Aug 2017 19:00:33 +0000 (+0000) Subject: [InlineCost] Small changes to early exit condition. NFC. X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=33be26f89361e721175635ed0195348a38fbffcc;p=llvm [InlineCost] Small changes to early exit condition. NFC. Change the early exit condition from Cost > Threshold to Cost >= Threshold because the inline condition is Cost < Threshold. Differential Revision: https://reviews.llvm.org/D37087 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@311791 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Analysis/InlineCost.cpp b/lib/Analysis/InlineCost.cpp index c26388a19bc..8cdf2046702 100644 --- a/lib/Analysis/InlineCost.cpp +++ b/lib/Analysis/InlineCost.cpp @@ -1384,7 +1384,7 @@ bool CallAnalyzer::analyzeBlock(BasicBlock *BB, // Check if we've past the maximum possible threshold so we don't spin in // huge basic blocks that will never inline. - if (Cost > Threshold && !ComputeFullInlineCost) + if (Cost >= Threshold && !ComputeFullInlineCost) return false; } @@ -1470,7 +1470,7 @@ bool CallAnalyzer::analyzeCall(CallSite CS) { Cost += InlineConstants::ColdccPenalty; // Check if we're done. This can happen due to bonuses and penalties. - if (Cost > Threshold && !ComputeFullInlineCost) + if (Cost >= Threshold && !ComputeFullInlineCost) return false; if (F.empty()) @@ -1536,7 +1536,7 @@ bool CallAnalyzer::analyzeCall(CallSite CS) { for (unsigned Idx = 0; Idx != BBWorklist.size(); ++Idx) { // Bail out the moment we cross the threshold. This means we'll under-count // the cost, but only when undercounting doesn't matter. - if (Cost > Threshold && !ComputeFullInlineCost) + if (Cost >= Threshold && !ComputeFullInlineCost) break; BasicBlock *BB = BBWorklist[Idx];