From: Matthew Fernandez <matthew.fernandez@gmail.com>
Date: Fri, 5 Aug 2022 04:29:21 +0000 (-0700)
Subject: expr: remove dereferencing and parens around calling 'Exdisc_t.keyf'
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=3366024b1607e5dbad5b55abcf414d7fef70bc1a;p=graphviz

expr: remove dereferencing and parens around calling 'Exdisc_t.keyf'

The compiler does not need to be explicitly told how to call through a function
pointer.
---

diff --git a/lib/expr/exeval.c b/lib/expr/exeval.c
index 5cdf90a68..49989ce6e 100644
--- a/lib/expr/exeval.c
+++ b/lib/expr/exeval.c
@@ -99,7 +99,7 @@ static int evaldyn(Expr_t *ex, Exnode_t *exnode, void *env, int delete) {
 		int type = exnode->data.variable.index->type;
 		if (type != STRING) {
 			if (!BUILTIN(type)) {
-				key = (*ex->disc->keyf) (v, type);
+				key = ex->disc->keyf(v, type);
 			} else
 				key.integer = v.integer;
 			snprintf(buf, sizeof(buf), "%llx", (unsigned long long)key.integer);
@@ -146,7 +146,7 @@ static Extype_t getdyn(Expr_t *ex, Exnode_t *exnode, void *env,
 			int type = exnode->data.variable.index->type;
 			if (type != STRING) {
 				if (!BUILTIN(type)) {
-					key = (*ex->disc->keyf) (v, type);
+					key = ex->disc->keyf(v, type);
 				} else
 					key.integer = v.integer;
 				snprintf(buf, sizeof(buf), "%llx", (unsigned long long)key.integer);