From: Alvaro Herrera Date: Thu, 26 Jan 2017 20:45:22 +0000 (-0300) Subject: Remove test for COMMENT ON DATABASE X-Git-Tag: REL_10_BETA1~1000 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=331f8c311b7ba4b24158071ab2fb2e07bb8377b0;p=postgresql Remove test for COMMENT ON DATABASE Our current DDL only allows a database name to be specified in COMMENT ON DATABASE, which Andrew Dunstan reports to make this test fail on the buildfarm. Remove the line until we gain a DDL command that allows the current database to be operated on without having the specify it by name. Backpatch to 9.5, where these tests appeared. Discussion: https://postgr.es/m/e6084b89-07a7-7e57-51ee-d7b8fc9ec864@2ndQuadrant.com --- diff --git a/src/test/modules/test_ddl_deparse/expected/comment_on.out b/src/test/modules/test_ddl_deparse/expected/comment_on.out index 4ebc89d611..8ce01e0f74 100644 --- a/src/test/modules/test_ddl_deparse/expected/comment_on.out +++ b/src/test/modules/test_ddl_deparse/expected/comment_on.out @@ -21,5 +21,3 @@ COMMENT ON TRIGGER trigger_1 ON datatype_table IS 'TRIGGER test'; NOTICE: DDL test: type simple, tag COMMENT COMMENT ON RULE rule_1 IS 'RULE test'; NOTICE: DDL test: type simple, tag COMMENT --- should not fire -COMMENT ON DATABASE contrib_regression IS 'contrib regression'; diff --git a/src/test/modules/test_ddl_deparse/sql/comment_on.sql b/src/test/modules/test_ddl_deparse/sql/comment_on.sql index 69114c3229..734d493d5a 100644 --- a/src/test/modules/test_ddl_deparse/sql/comment_on.sql +++ b/src/test/modules/test_ddl_deparse/sql/comment_on.sql @@ -12,6 +12,3 @@ COMMENT ON VIEW datatype_view IS 'This is a view'; COMMENT ON FUNCTION c_function_test() IS 'FUNCTION test'; COMMENT ON TRIGGER trigger_1 ON datatype_table IS 'TRIGGER test'; COMMENT ON RULE rule_1 IS 'RULE test'; - --- should not fire -COMMENT ON DATABASE contrib_regression IS 'contrib regression';