From: Jay Satiro <raysatiro@yahoo.com>
Date: Thu, 23 Nov 2017 07:47:26 +0000 (-0500)
Subject: connect: improve the bind error message
X-Git-Tag: curl-7_57_0~17
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=31f18d272;p=curl

connect: improve the bind error message

eg consider a non-existent interface eth8, curl --interface eth8

Before: curl: (45) Could not resolve host: eth8
After: curl: (45) Couldn't bind to 'eth8'

Bug: https://github.com/curl/curl/issues/2104
Reported-by: Alfonso Martone
---

diff --git a/lib/connect.c b/lib/connect.c
index 16104bc4f..45e18bc07 100644
--- a/lib/connect.c
+++ b/lib/connect.c
@@ -412,6 +412,10 @@ static CURLcode bindlocal(struct connectdata *conn,
     }
 
     if(done < 1) {
+      /* errorbuf is set false so failf will overwrite any message already in
+         the error buffer, so the user receives this error message instead of a
+         generic resolve error. */
+      data->state.errorbuf = FALSE;
       failf(data, "Couldn't bind to '%s'", dev);
       return CURLE_INTERFACE_FAILED;
     }