From: Martin Storsjo Date: Mon, 17 Mar 2014 10:21:31 +0000 (+0200) Subject: thumb: Clarify a comment about the conversions that are done X-Git-Tag: v1.4.0~2056^2 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=317e07eedb924b395c2c71e264ae15ba5114add3;p=libvpx thumb: Clarify a comment about the conversions that are done The comment made it look like the condition code was dropped from the extra add instruction, while it actually was handled properly. Thus, the comment was misleading while the code itself did the right thing. Also clarify the comment indicating that we use the full three-operand form of the add instruction. Change-Id: I2c1ac6ac4fedf262d104ea30a6c005febc74de9c --- diff --git a/build/make/thumb.pm b/build/make/thumb.pm index 9604c8e32..483c2539c 100644 --- a/build/make/thumb.pm +++ b/build/make/thumb.pm @@ -51,7 +51,7 @@ sub FixThumbInstructions($$) # Convert register post indexing to a separate add instruction. # This converts "ldrneb r9, [r0], r2" into "ldrneb r9, [r0]", - # "add r0, r2". + # "addne r0, r0, r2". s/^(\s*)((ldr|str)(ne)?[bhd]?)(\s+)(\w+),(\s*\w+,)?\s*\[(\w+)\],\s*(\w+)/$1$2$5$6,$7 [$8]\n$1add$4$5$8, $8, $9/g; # Convert a conditional addition to the pc register into a series of