From: Guido van Rossum Date: Thu, 29 Nov 2007 18:25:12 +0000 (+0000) Subject: Fix bug #1517, a segfault in lookdict(). X-Git-Tag: v2.6a1~986 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=31645ba4a06dcd66e84d6fdd611c5ad02401fa8c;p=python Fix bug #1517, a segfault in lookdict(). --- diff --git a/Objects/dictobject.c b/Objects/dictobject.c index bfb891c755..cd1338aed3 100644 --- a/Objects/dictobject.c +++ b/Objects/dictobject.c @@ -270,7 +270,9 @@ lookdict(PyDictObject *mp, PyObject *key, register long hash) else { if (ep->me_hash == hash) { startkey = ep->me_key; + Py_INCREF(startkey); cmp = PyObject_RichCompareBool(startkey, key, Py_EQ); + Py_DECREF(startkey); if (cmp < 0) return NULL; if (ep0 == mp->ma_table && ep->me_key == startkey) { @@ -300,7 +302,9 @@ lookdict(PyDictObject *mp, PyObject *key, register long hash) return ep; if (ep->me_hash == hash && ep->me_key != dummy) { startkey = ep->me_key; + Py_INCREF(startkey); cmp = PyObject_RichCompareBool(startkey, key, Py_EQ); + Py_DECREF(startkey); if (cmp < 0) return NULL; if (ep0 == mp->ma_table && ep->me_key == startkey) {