From: Andres Freund <andres@anarazel.de>
Date: Mon, 23 Sep 2019 22:28:13 +0000 (-0700)
Subject: Fix ExprState's tag to be of type NodeTag rather than Node.
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=30d13796582fe13df0cbea1a8605d926a454d32f;p=postgresql

Fix ExprState's tag to be of type NodeTag rather than Node.

This appears to have been an oversight in b8d7f053c5c2. As it's
effectively harmless, though confusing, only fix in master.

Author: Andres Freund
---

diff --git a/src/backend/executor/execExpr.c b/src/backend/executor/execExpr.c
index 20ee1d3fb4..39442f8866 100644
--- a/src/backend/executor/execExpr.c
+++ b/src/backend/executor/execExpr.c
@@ -361,7 +361,7 @@ ExecBuildProjectionInfo(List *targetList,
 
 	projInfo->pi_exprContext = econtext;
 	/* We embed ExprState into ProjectionInfo instead of doing extra palloc */
-	projInfo->pi_state.tag.type = T_ExprState;
+	projInfo->pi_state.tag = T_ExprState;
 	state = &projInfo->pi_state;
 	state->expr = (Expr *) targetList;
 	state->parent = parent;
diff --git a/src/include/nodes/execnodes.h b/src/include/nodes/execnodes.h
index b593d22c48..44f76082e9 100644
--- a/src/include/nodes/execnodes.h
+++ b/src/include/nodes/execnodes.h
@@ -61,7 +61,7 @@ typedef Datum (*ExprStateEvalFunc) (struct ExprState *expression,
 
 typedef struct ExprState
 {
-	Node		tag;
+	NodeTag		tag;
 
 	uint8		flags;			/* bitmask of EEO_FLAG_* bits, see above */