From: Jon Parise <jon@php.net>
Date: Mon, 17 Jul 2006 01:17:00 +0000 (+0000)
Subject: If the $PHP_AUTOCONF and $PHP_AUTOHEADER environmental variables are set
X-Git-Tag: RELEASE_1_0_0RC1~2377
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=3078bbabfd80203d0914ff6a1c313423eb58213d;p=php

If the $PHP_AUTOCONF and $PHP_AUTOHEADER environmental variables are set
to full paths, the `shtool path` test would fail (because it only tests
for the existence of a bare filename in the current $PATH).  We now test
the the executability of $PHP_AUTOCONF and $PHP_AUTOHEADER before falling
back to the `shtool path` test.

Later on, phpize will execute $PHP_AUTOCONF and $PHP_AUTOHEADER directly,
so they will work fine as either absolute paths or files within $PATH.

Also, improving the grammar of the error messages in the failure cases.
---

diff --git a/scripts/phpize.in b/scripts/phpize.in
index c62a32af2e..1394c65476 100644
--- a/scripts/phpize.in
+++ b/scripts/phpize.in
@@ -102,19 +102,18 @@ phpize_check_autotools()
   test -z "$PHP_AUTOCONF" && PHP_AUTOCONF=autoconf
   test -z "$PHP_AUTOHEADER" && PHP_AUTOHEADER=autoheader
   
-  if ! test -x "`$php_shtool path $PHP_AUTOCONF`"; then
+  if ! text -x $PHP_AUTOCONF && ! test -x "`$php_shtool path $PHP_AUTOCONF`"; then
     cat <<EOF
 Cannot find autoconf. Please check your autoconf installation and the
-\$PHP_AUTOCONF environment variable is set correctly and then rerun this script.
+\$PHP_AUTOCONF environment variable. Then, rerun this script.
 
 EOF
     exit 1
   fi
-  if ! test -x "`$php_shtool path $PHP_AUTOHEADER`"; then
+  if ! test -x $PHP_AUTOHEADER && ! test -x "`$php_shtool path $PHP_AUTOHEADER`"; then
     cat <<EOF
 Cannot find autoheader. Please check your autoconf installation and the
-\$PHP_AUTOHEADER environment variable is set correctly and then rerun this
-script.
+\$PHP_AUTOHEADER environment variable. Then, rerun this script.
 
 EOF
     exit 1