From: Daniel Stenberg <daniel@haxx.se>
Date: Mon, 24 Feb 2003 14:50:20 +0000 (+0000)
Subject: Kjetil Jacobsen found out that setting CURLOPT_MAXCONNECTS to a value higher
X-Git-Tag: curl-7_10_4~128
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=30639ed72b2d0552435e22f17d1e2cebc86cc4ea;p=curl

Kjetil Jacobsen found out that setting CURLOPT_MAXCONNECTS to a value higher
than 5 could cause a segfault.
---

diff --git a/lib/url.c b/lib/url.c
index 0836b24ab..865c247d5 100644
--- a/lib/url.c
+++ b/lib/url.c
@@ -378,12 +378,19 @@ CURLcode Curl_setopt(struct SessionHandle *data, CURLoption option, ...)
           Curl_disconnect(data->state.connects[i]);
       }
       if(newconnects) {
+        int i;
         newptr= (struct connectdata **)
           realloc(data->state.connects,
                   sizeof(struct connectdata *) * newconnects);
         if(!newptr)
           /* we closed a few connections in vain, but so what? */
           return CURLE_OUT_OF_MEMORY;
+
+        /* nullify the newly added pointers */
+        for(i=data->state.numconnects; i<newconnects; i++) {
+          newptr[i] = NULL;
+        }
+
         data->state.connects = newptr;
         data->state.numconnects = newconnects;
       }