From: Gabor Marton Date: Fri, 7 Dec 2018 16:05:58 +0000 (+0000) Subject: [CTU] Add more lit tests and better error handling X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=30370cd4cdde50b82171378e3b0dc6ec4e855d10;p=clang [CTU] Add more lit tests and better error handling Summary: Adding some more CTU list tests. E.g. to check if a construct is unsupported. We also slightly modify the handling of the return value of the `Import` function from ASTImporter. Reviewers: xazax.hun, balazske, a_sidorin Subscribers: rnkovacs, dkrupp, Szelethus, gamesh411, cfe-commits Differential Revision: https://reviews.llvm.org/D55131 git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@348605 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/CrossTU/CrossTranslationUnit.cpp b/lib/CrossTU/CrossTranslationUnit.cpp index 7d4f0ec9b4..ec8ac6498f 100644 --- a/lib/CrossTU/CrossTranslationUnit.cpp +++ b/lib/CrossTU/CrossTranslationUnit.cpp @@ -269,7 +269,9 @@ CrossTranslationUnitContext::importDefinition(const FunctionDecl *FD) { ASTImporter &Importer = getOrCreateASTImporter(FD->getASTContext()); auto *ToDecl = - cast(Importer.Import(const_cast(FD))); + cast_or_null(Importer.Import(const_cast(FD))); + if (!ToDecl) + return llvm::make_error(index_error_code::failed_import); assert(ToDecl->hasBody()); assert(FD->hasBody() && "Functions already imported should have body."); ++NumGetCTUSuccess; diff --git a/test/Analysis/Inputs/ctu-other.c b/test/Analysis/Inputs/ctu-other.c new file mode 100644 index 0000000000..9a95206110 --- /dev/null +++ b/test/Analysis/Inputs/ctu-other.c @@ -0,0 +1,49 @@ +// Test typedef and global variable in function. +typedef struct { + int a; + int b; +} FooBar; +FooBar fb; +int f(int i) { + if (fb.a) { + fb.b = i; + } + return 1; +} + +// Test enums. +enum B { x = 42, + l, + s }; +int enumCheck(void) { + return x; +} + +// Test reporting an error in macro definition +#define MYMACRO(ctx) \ + ctx->a; +struct S { + int a; +}; +int g(struct S *ctx) { + MYMACRO(ctx); + return 0; +} + +// Test that asm import does not fail. +int inlineAsm() { + int res; + asm("mov $42, %0" + : "=r"(res)); + return res; +} + +// Implicit function. +int identImplicit(int in) { + return in; +} + +// ASTImporter doesn't support this construct. +int structInProto(struct DataType {int a;int b; } * d) { + return 0; +} diff --git a/test/Analysis/Inputs/ctu-other.c.externalFnMap.txt b/test/Analysis/Inputs/ctu-other.c.externalFnMap.txt new file mode 100644 index 0000000000..9abaa501a4 --- /dev/null +++ b/test/Analysis/Inputs/ctu-other.c.externalFnMap.txt @@ -0,0 +1,6 @@ +c:@F@inlineAsm ctu-other.c.ast +c:@F@g ctu-other.c.ast +c:@F@f ctu-other.c.ast +c:@F@enumCheck ctu-other.c.ast +c:@F@identImplicit ctu-other.c.ast +c:@F@structInProto ctu-other.c.ast diff --git a/test/Analysis/Inputs/externalFnMap.txt b/test/Analysis/Inputs/ctu-other.cpp.externalFnMap.txt similarity index 100% rename from test/Analysis/Inputs/externalFnMap.txt rename to test/Analysis/Inputs/ctu-other.cpp.externalFnMap.txt diff --git a/test/Analysis/ctu-main.c b/test/Analysis/ctu-main.c new file mode 100644 index 0000000000..239d51ab49 --- /dev/null +++ b/test/Analysis/ctu-main.c @@ -0,0 +1,67 @@ +// RUN: rm -rf %t && mkdir %t +// RUN: mkdir -p %t/ctudir2 +// RUN: %clang_cc1 -triple x86_64-pc-linux-gnu \ +// RUN: -emit-pch -o %t/ctudir2/ctu-other.c.ast %S/Inputs/ctu-other.c +// RUN: cp %S/Inputs/ctu-other.c.externalFnMap.txt %t/ctudir2/externalFnMap.txt +// RUN: %clang_cc1 -triple x86_64-pc-linux-gnu -fsyntax-only -std=c89 -analyze \ +// RUN: -analyzer-checker=core,debug.ExprInspection \ +// RUN: -analyzer-config experimental-enable-naive-ctu-analysis=true \ +// RUN: -analyzer-config ctu-dir=%t/ctudir2 \ +// RUN: -verify %s + +void clang_analyzer_eval(int); + +// Test typedef and global variable in function. +typedef struct { + int a; + int b; +} FooBar; +extern FooBar fb; +int f(int); +void testGlobalVariable() { + clang_analyzer_eval(f(5) == 1); // expected-warning{{TRUE}} +} + +// Test enums. +int enumCheck(void); +enum A { x, + y, + z }; +void testEnum() { + clang_analyzer_eval(x == 0); // expected-warning{{TRUE}} + clang_analyzer_eval(enumCheck() == 42); // expected-warning{{TRUE}} +} + +// Test that asm import does not fail. +int inlineAsm(); +int testInlineAsm() { + return inlineAsm(); +} + +// Test reporting error in a macro. +struct S; +int g(struct S *); +void testMacro(void) { + g(0); // expected-warning@Inputs/ctu-other.c:29 {{Access to field 'a' results in a dereference of a null pointer (loaded from variable 'ctx')}} +} + +// The external function prototype is incomplete. +// warning:implicit functions are prohibited by c99 +void testImplicit() { + int res = identImplicit(6); // external implicit functions are not inlined + clang_analyzer_eval(res == 6); // expected-warning{{TRUE}} +} + +// Tests the import of functions that have a struct parameter +// defined in its prototype. +struct DataType { + int a; + int b; +}; +int structInProto(struct DataType *d); +void testStructDefInArgument() { + struct DataType d; + d.a = 1; + d.b = 0; + clang_analyzer_eval(structInProto(&d) == 0); // expected-warning{{TRUE}} expected-warning{{FALSE}} +} diff --git a/test/Analysis/ctu-main.cpp b/test/Analysis/ctu-main.cpp index 3bd5d24bd0..a978329ad8 100644 --- a/test/Analysis/ctu-main.cpp +++ b/test/Analysis/ctu-main.cpp @@ -4,7 +4,7 @@ // RUN: -emit-pch -o %t/ctudir/ctu-other.cpp.ast %S/Inputs/ctu-other.cpp // RUN: %clang_cc1 -triple x86_64-pc-linux-gnu \ // RUN: -emit-pch -o %t/ctudir/ctu-chain.cpp.ast %S/Inputs/ctu-chain.cpp -// RUN: cp %S/Inputs/externalFnMap.txt %t/ctudir/ +// RUN: cp %S/Inputs/ctu-other.cpp.externalFnMap.txt %t/ctudir/externalFnMap.txt // RUN: %clang_analyze_cc1 -triple x86_64-pc-linux-gnu \ // RUN: -analyzer-checker=core,debug.ExprInspection \ // RUN: -analyzer-config experimental-enable-naive-ctu-analysis=true \