From: Simon Pilgrim Date: Tue, 20 Aug 2019 11:20:05 +0000 (+0000) Subject: [CMake] Update C4324 MSVC warning comment to explain its still broken at VS2019 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=301861b35821b6d311d49ee4becac95a31743932;p=llvm [CMake] Update C4324 MSVC warning comment to explain its still broken at VS2019 As promised, I've updated the comment for the C4324 MSVC warning that was re-disabled at rL367409 / rG8f823e63e3edf87ab029ba32b68f3eb5d2f392b5 to put it in terms of currently supported VS versions git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369368 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/cmake/modules/HandleLLVMOptions.cmake b/cmake/modules/HandleLLVMOptions.cmake index f6dafc10d7a..e55bcab6e03 100644 --- a/cmake/modules/HandleLLVMOptions.cmake +++ b/cmake/modules/HandleLLVMOptions.cmake @@ -543,12 +543,10 @@ if (MSVC) # is fixed. -wd4709 # Suppress comma operator within array index expression - # Ideally, we'd like this warning to be enabled, but MSVC 2013 doesn't + # Ideally, we'd like this warning to be enabled, but even MSVC 2019 doesn't # support the 'aligned' attribute in the way that clang sources requires (for # any code that uses the LLVM_ALIGNAS macro), so this is must be disabled to # avoid unwanted alignment warnings. - # When we switch to requiring a version of MSVC that supports the 'alignas' - # specifier (MSVC 2015?) this warning can be re-enabled. -wd4324 # Suppress 'structure was padded due to __declspec(align())' # Promoted warnings.