From: Dmitry V. Levin <ldv@altlinux.org>
Date: Wed, 28 Jan 2015 01:26:04 +0000 (+0000)
Subject: decode_select: do not allocate unused memory
X-Git-Tag: v4.10~158
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=2fc5d80858d3aece2a5a410f811415e51c194faf;p=strace

decode_select: do not allocate unused memory

* desc.c (decode_select): On entering syscall, do not allocate memory
in non-verbose mode.
---

diff --git a/desc.c b/desc.c
index 491e9ba9..24de51de 100644
--- a/desc.c
+++ b/desc.c
@@ -338,7 +338,7 @@ decode_select(struct tcb *tcp, long *args, enum bitness_t bitness)
 	if (entering(tcp)) {
 		tprintf("%d", (int) args[0]);
 
-		if (fdsize > 0) {
+		if (verbose(tcp) && fdsize > 0) {
 			fds = malloc(fdsize);
 			if (!fds)
 				die_out_of_memory();
@@ -349,7 +349,7 @@ decode_select(struct tcb *tcp, long *args, enum bitness_t bitness)
 				tprints(", NULL");
 				continue;
 			}
-			if (!verbose(tcp) || !fds) {
+			if (!fds) {
 				tprintf(", %#lx", arg);
 				continue;
 			}