From: Senthil Kumaran <senthil@uthcode.com>
Date: Thu, 24 May 2012 13:56:17 +0000 (+0800)
Subject: Issue #14036: return None when port in urlparse cross 65535
X-Git-Tag: v3.3.0a4~85^2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=2fc5a5080923f243a78b13cca0fd09f8db26eff6;p=python

Issue #14036: return None when port in urlparse cross 65535
---

diff --git a/Lib/test/test_urlparse.py b/Lib/test/test_urlparse.py
index 73150cffa6..e9adaefbd5 100755
--- a/Lib/test/test_urlparse.py
+++ b/Lib/test/test_urlparse.py
@@ -524,6 +524,11 @@ class UrlParseTestCase(unittest.TestCase):
         self.assertEqual(p.port, 80)
         self.assertEqual(p.geturl(), url)
 
+        # Verify an illegal port is returned as None
+        url = b"HTTP://WWW.PYTHON.ORG:65536/doc/#frag"
+        p = urllib.parse.urlsplit(url)
+        self.assertEqual(p.port, None)
+
     def test_attributes_bad_port(self):
         """Check handling of non-integer ports."""
         p = urllib.parse.urlsplit("http://www.example.net:foo")
diff --git a/Lib/urllib/parse.py b/Lib/urllib/parse.py
index 92170ad0a2..528c0a7aaf 100644
--- a/Lib/urllib/parse.py
+++ b/Lib/urllib/parse.py
@@ -143,6 +143,9 @@ class _NetlocResultMixinBase(object):
         port = self._hostinfo[1]
         if port is not None:
             port = int(port, 10)
+            # Return None on an illegal port
+            if not ( 0 <= port <= 65535):
+                return None
         return port
 
 
diff --git a/Misc/NEWS b/Misc/NEWS
index 7ed8f152f9..d9b8b5cf84 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -67,6 +67,9 @@ Core and Builtins
 Library
 -------
 
+- Issue #14036: Add an additional check to validate that port in urlparse does
+  not go in illegal range and returns None.
+
 - Issue #14875: Use float('inf') instead of float('1e66666') in the json module.
 
 - Issue #14426: Correct the Date format in Expires attribute of Set-Cookie