From: Qualys Security Advisory <qsa@qualys.com>
Date: Thu, 1 Jan 1970 00:00:00 +0000 (+0000)
Subject: uptime: Check the return value of various functions.
X-Git-Tag: v3.3.15~133
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=2fc42db322e64ba1c063b36cdbd29da4ce1c9f7a;p=procps-ng

uptime: Check the return value of various functions.
---

diff --git a/uptime.c b/uptime.c
index 91275ca8..4db15f77 100644
--- a/uptime.c
+++ b/uptime.c
@@ -39,15 +39,18 @@ static void print_uptime_since()
 	struct timeval tim;
 
 	/* Get the current time and convert it to a double */
-	gettimeofday(&tim, NULL);
+	if (gettimeofday(&tim, NULL) != 0)
+		xerr(EXIT_FAILURE, "gettimeofday");
 	now = tim.tv_sec + (tim.tv_usec / 1000000.0);
 
 	/* Get the uptime and calculate when that was */
-	uptime(&uptime_secs, &idle_secs);
+	if (uptime(&uptime_secs, &idle_secs) == 0)
+		xerrx(EXIT_FAILURE, "uptime");
 	up_since_secs = (time_t) ((now - uptime_secs) + 0.5);
 
 	/* Show this */
-	up_since = localtime(&up_since_secs);
+	if ((up_since = localtime(&up_since_secs)) == NULL)
+		xerrx(EXIT_FAILURE, "localtime");
 	printf("%04d-%02d-%02d %02d:%02d:%02d\n",
 		up_since->tm_year + 1900, up_since->tm_mon + 1, up_since->tm_mday,
 		up_since->tm_hour, up_since->tm_min, up_since->tm_sec);