From: Ahmed Bougacha Date: Tue, 2 May 2017 00:45:01 +0000 (+0000) Subject: [AArch64] armv8-A doesn't have LSE. X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=2f6226dcbdec66bfe9d79a521d713d57502407da;p=llvm [AArch64] armv8-A doesn't have LSE. r288279 mistakenly added it to all arches, but it's only available from v8.1 onwards. The testcase is awkward, because (I suspect) of PR32873. Spotted by inspection. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@301890 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/include/llvm/Support/AArch64TargetParser.def b/include/llvm/Support/AArch64TargetParser.def index 46d253bf0ec..1700deadeae 100644 --- a/include/llvm/Support/AArch64TargetParser.def +++ b/include/llvm/Support/AArch64TargetParser.def @@ -21,7 +21,7 @@ AARCH64_ARCH("invalid", AK_INVALID, nullptr, nullptr, AARCH64_ARCH("armv8-a", AK_ARMV8A, "8-A", "v8", ARMBuildAttrs::CPUArch::v8_A, FK_CRYPTO_NEON_FP_ARMV8, (AArch64::AEK_CRC | AArch64::AEK_CRYPTO | AArch64::AEK_FP | - AArch64::AEK_SIMD | AArch64::AEK_LSE)) + AArch64::AEK_SIMD)) AARCH64_ARCH("armv8.1-a", AK_ARMV8_1A, "8.1-A", "v8.1a", ARMBuildAttrs::CPUArch::v8_A, FK_CRYPTO_NEON_FP_ARMV8, (AArch64::AEK_CRC | AArch64::AEK_CRYPTO | AArch64::AEK_FP | diff --git a/test/MC/AArch64/directive-arch-negative.s b/test/MC/AArch64/directive-arch-negative.s index 43ccd792725..21fd90ebdf1 100644 --- a/test/MC/AArch64/directive-arch-negative.s +++ b/test/MC/AArch64/directive-arch-negative.s @@ -36,6 +36,14 @@ # CHECK: error: instruction requires: ras # CHECK: esb +// PR32873: without extra features, '.arch' is currently ignored. +// Add an unrelated feature to accept the directive. + .arch armv8+crc + casa w5, w7, [x19] + +# CHECK: error: instruction requires: lse +# CHECK: casa w5, w7, [x19] + .arch armv8.1-a+nolse casa w5, w7, [x20]