From: Matt Caswell <matt@openssl.org>
Date: Mon, 22 Aug 2016 21:17:20 +0000 (+0100)
Subject: Fix leak on error in tls_construct_cke_gost
X-Git-Tag: OpenSSL_1_1_0~79
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=2f3930bc0edbfdc7718f709b856fa53f0ec57cde;p=openssl

Fix leak on error in tls_construct_cke_gost

Don't leak pke_ctx on error.

Reviewed-by: Tim Hudson <tjh@openssl.org>
---

diff --git a/ssl/statem/statem_clnt.c b/ssl/statem/statem_clnt.c
index 8f250cdc13..ff42858ff3 100644
--- a/ssl/statem/statem_clnt.c
+++ b/ssl/statem/statem_clnt.c
@@ -2368,7 +2368,7 @@ static int tls_construct_cke_gost(SSL *s, unsigned char **p, int *len, int *al)
     if (pms == NULL) {
         *al = SSL_AD_INTERNAL_ERROR;
         SSLerr(SSL_F_TLS_CONSTRUCT_CKE_GOST, ERR_R_MALLOC_FAILURE);
-        return 0;
+        goto err;
     }
 
     if (EVP_PKEY_encrypt_init(pkey_ctx) <= 0