From: Matthew Fernandez <matthew.fernandez@gmail.com>
Date: Wed, 4 Jan 2023 04:25:32 +0000 (-0800)
Subject: expr xPrint: remove shadowing of 'expr' global
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=2f122cb3b1a0114bb0dcee37d0a7ba95cb014193;p=graphviz

expr xPrint: remove shadowing of 'expr' global
---

diff --git a/lib/expr/exeval.c b/lib/expr/exeval.c
index 2b1833e4a..f9f2b9ef3 100644
--- a/lib/expr/exeval.c
+++ b/lib/expr/exeval.c
@@ -1084,15 +1084,13 @@ static void xConvert(Expr_t *ex, Exnode_t *exnode, int type, Extype_t v,
 /* xPrint:
  * Generate string representation from value of external type.
  */
-static void
-xPrint(Expr_t * ex, Exnode_t * expr, Extype_t v, Exnode_t * tmp)
-{
-	*tmp = *expr->data.operand.left;
+static void xPrint(Expr_t *ex, Exnode_t *exnode, Extype_t v, Exnode_t *tmp) {
+	*tmp = *exnode->data.operand.left;
 	tmp->data.constant.value = v;
 	if (ex->disc->stringof(ex, tmp, 0))
 	exerror("%s: no string representation of %s value",
-		expr->data.operand.left->data.variable.symbol->name,
-		extypename(ex, expr->data.operand.left->type));
+		exnode->data.operand.left->data.variable.symbol->name,
+		extypename(ex, exnode->data.operand.left->type));
 	tmp->type = STRING;
 }