From: Éric Araujo Date: Sat, 4 Jun 2011 20:33:16 +0000 (+0200) Subject: Cleanup in packaging: don’t unnecessarily instantiate exceptions X-Git-Tag: v3.3.0a1~2172^2~12 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=2ef747cb778a45ec7eb96f5ba5f725bbf53e970c;p=python Cleanup in packaging: don’t unnecessarily instantiate exceptions --- diff --git a/Lib/packaging/pypi/dist.py b/Lib/packaging/pypi/dist.py index 16510dffd8..db04cdaa70 100644 --- a/Lib/packaging/pypi/dist.py +++ b/Lib/packaging/pypi/dist.py @@ -135,7 +135,7 @@ class ReleaseInfo(IndexReference): not return one existing distribution. """ if len(self.dists) == 0: - raise LookupError() + raise LookupError if dist_type: return self[dist_type] if prefer_source: diff --git a/Lib/packaging/pypi/simple.py b/Lib/packaging/pypi/simple.py index c492179874..c372c6fe3e 100644 --- a/Lib/packaging/pypi/simple.py +++ b/Lib/packaging/pypi/simple.py @@ -189,7 +189,7 @@ class Crawler(BaseClient): self._process_index_page(predicate.name) if predicate.name.lower() not in self._projects: - raise ProjectNotFound() + raise ProjectNotFound releases = self._projects.get(predicate.name.lower()) releases.sort_releases(prefer_final=prefer_final) diff --git a/Lib/packaging/run.py b/Lib/packaging/run.py index 1895dde4cc..7e791a4a3c 100644 --- a/Lib/packaging/run.py +++ b/Lib/packaging/run.py @@ -383,7 +383,7 @@ def _search(dispatcher, args, **kw): """ #opts = _parse_args(args[1:], '', ['simple', 'xmlrpc']) # 1. what kind of index is requested ? (xmlrpc / simple) - raise NotImplementedError() + raise NotImplementedError actions = [ diff --git a/Lib/packaging/tests/test_uninstall.py b/Lib/packaging/tests/test_uninstall.py index 4b37286059..00e97e4c70 100644 --- a/Lib/packaging/tests/test_uninstall.py +++ b/Lib/packaging/tests/test_uninstall.py @@ -111,7 +111,7 @@ class UninstallTestCase(support.TempdirManager, old = os.rename def _rename(source, target): - raise OSError() + raise OSError os.rename = _rename try: