From: Teresa Johnson <tejohnson@google.com>
Date: Tue, 2 Jul 2019 21:07:45 +0000 (+0000)
Subject: [ThinLTO] Address post-review suggestions for index-based WPD summary
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=2eecf3fbcd7bd5b13904116c7dbbf0a1f6323042;p=llvm

[ThinLTO] Address post-review suggestions for index-based WPD summary

Removes a couple of unnecessary and/or redundant checks introduced by
r364960.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@364968 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Bitcode/Writer/BitcodeWriter.cpp b/lib/Bitcode/Writer/BitcodeWriter.cpp
index 96e1d493aaf..837f883c5b9 100644
--- a/lib/Bitcode/Writer/BitcodeWriter.cpp
+++ b/lib/Bitcode/Writer/BitcodeWriter.cpp
@@ -3688,20 +3688,19 @@ void ModuleBitcodeWriterBase::writeModuleLevelReferences(
   // been initialized from a DenseSet.
   llvm::sort(NameVals.begin() + SizeBeforeRefs, NameVals.end());
 
-  if (!VTableFuncs.empty()) {
+  if (VTableFuncs.empty())
+    Stream.EmitRecord(bitc::FS_PERMODULE_GLOBALVAR_INIT_REFS, NameVals,
+                      FSModRefsAbbrev);
+  else {
     // VTableFuncs pairs should already be sorted by offset.
     for (auto &P : VTableFuncs) {
       NameVals.push_back(VE.getValueID(P.FuncVI.getValue()));
       NameVals.push_back(P.VTableOffset);
     }
-  }
 
-  if (VTableFuncs.empty())
-    Stream.EmitRecord(bitc::FS_PERMODULE_GLOBALVAR_INIT_REFS, NameVals,
-                      FSModRefsAbbrev);
-  else
     Stream.EmitRecord(bitc::FS_PERMODULE_VTABLE_GLOBALVAR_INIT_REFS, NameVals,
                       FSModVTableRefsAbbrev);
+  }
   NameVals.clear();
 }
 
@@ -3854,14 +3853,12 @@ void ModuleBitcodeWriterBase::writePerModuleGlobalValueSummary() {
     NameVals.clear();
   }
 
-  if (!Index->typeIdCompatibleVtableMap().empty()) {
-    for (auto &S : Index->typeIdCompatibleVtableMap()) {
-      writeTypeIdCompatibleVtableSummaryRecord(NameVals, StrtabBuilder, S.first,
-                                               S.second, VE);
-      Stream.EmitRecord(bitc::FS_TYPE_ID_METADATA, NameVals,
-                        TypeIdCompatibleVtableAbbrev);
-      NameVals.clear();
-    }
+  for (auto &S : Index->typeIdCompatibleVtableMap()) {
+    writeTypeIdCompatibleVtableSummaryRecord(NameVals, StrtabBuilder, S.first,
+                                             S.second, VE);
+    Stream.EmitRecord(bitc::FS_TYPE_ID_METADATA, NameVals,
+                      TypeIdCompatibleVtableAbbrev);
+    NameVals.clear();
   }
 
   Stream.ExitBlock();