From: Bruce Momjian <bruce@momjian.us>
Date: Thu, 29 Sep 2011 02:53:44 +0000 (-0400)
Subject: In pg_upgrade, because toast table names can be mismatched with the heap
X-Git-Tag: REL9_1_2~93
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=2e9633c3620d4cbaa44ae61180f73137d0c63ccf;p=postgresql

In pg_upgrade, because toast table names can be mismatched with the heap
oid on 8.4, modify the toast name comparison test to only apply to old
9.0+ servers.  (The test was previously 8.4+.)
---

diff --git a/contrib/pg_upgrade/info.c b/contrib/pg_upgrade/info.c
index f66160fca1..7e177d4571 100644
--- a/contrib/pg_upgrade/info.c
+++ b/contrib/pg_upgrade/info.c
@@ -55,12 +55,15 @@ gen_db_file_maps(DbInfo *old_db, DbInfo *new_db,
 				   old_db->db_name, old_rel->reloid, new_rel->reloid);
 
 		/*
-		 * In pre-8.4, TOAST table names change during CLUSTER;  in >= 8.4
-		 * TOAST relation names always use heap table oids, hence we cannot
-		 * check relation names when upgrading from pre-8.4.
+		 * TOAST table names initially match the heap pg_class oid.
+		 * In pre-8.4, TOAST table names change during CLUSTER; in pre-9.0,
+		 * TOAST table names change during ALTER TABLE ALTER COLUMN SET TYPE.
+		 * In >= 9.0, TOAST relation names always use heap table oids, hence
+		 * we cannot check relation names when upgrading from pre-9.0.
+		 * Clusters upgraded to 9.0 will get matching TOAST names.
 		 */
 		if (strcmp(old_rel->nspname, new_rel->nspname) != 0 ||
-			((GET_MAJOR_VERSION(old_cluster.major_version) >= 804 ||
+			((GET_MAJOR_VERSION(old_cluster.major_version) >= 900 ||
 			  strcmp(old_rel->nspname, "pg_toast") != 0) &&
 			 strcmp(old_rel->relname, new_rel->relname) != 0))
 			pg_log(PG_FATAL, "Mismatch of relation names: database \"%s\", "