From: Daniel Stenberg <daniel@haxx.se>
Date: Thu, 19 Sep 2019 07:37:06 +0000 (+0200)
Subject: easy: part of conditional expression is always true: !result
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=2e68e5a023c0723521b1867814ce48e688cb9200;p=curl

easy: part of conditional expression is always true: !result

Fixes warning detected by PVS-Studio
Fixes #4374
---

diff --git a/lib/easy.c b/lib/easy.c
index 0b0016be4..cbb65a5f6 100644
--- a/lib/easy.c
+++ b/lib/easy.c
@@ -1020,9 +1020,8 @@ CURLcode curl_easy_pause(struct Curl_easy *data, int action)
 
   /* if there's no error and we're not pausing both directions, we want
      to have this handle checked soon */
-  if(!result &&
-     ((newstate&(KEEP_RECV_PAUSE|KEEP_SEND_PAUSE)) !=
-      (KEEP_RECV_PAUSE|KEEP_SEND_PAUSE)) ) {
+  if((newstate & (KEEP_RECV_PAUSE|KEEP_SEND_PAUSE)) !=
+     (KEEP_RECV_PAUSE|KEEP_SEND_PAUSE)) {
     Curl_expire(data, 0, EXPIRE_RUN_NOW); /* get this handle going again */
     if(data->multi)
       Curl_update_timer(data->multi);