From: Nikita Popov <nikita.ppv@gmail.com>
Date: Fri, 12 Jul 2019 08:43:32 +0000 (+0200)
Subject: Swap implode() argument order in some tests
X-Git-Tag: php-7.4.0beta1~152
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=2e56e14e39ee7917d255e22656f3f96cc7c89842;p=php

Swap implode() argument order in some tests
---

diff --git a/ext/spl/tests/arrayObject_getIteratorClass_basic1.phpt b/ext/spl/tests/arrayObject_getIteratorClass_basic1.phpt
index a749493007..e6e950c628 100644
--- a/ext/spl/tests/arrayObject_getIteratorClass_basic1.phpt
+++ b/ext/spl/tests/arrayObject_getIteratorClass_basic1.phpt
@@ -6,36 +6,36 @@ class MyIterator extends ArrayIterator {
 
 	function __construct() {
 	 	$args = func_get_args();
-		echo "   In " . __METHOD__ . "(" . implode($args, ',') . ")\n";
+		echo "   In " . __METHOD__ . "(" . implode(',', $args) . ")\n";
 	}
 
 	function rewind() {
 		$args = func_get_args();
-		echo "   In " . __METHOD__ . "(" . implode($args, ',') . ")\n";
+		echo "   In " . __METHOD__ . "(" . implode(',', $args) . ")\n";
 		return parent::rewind();
 	}
 
 	function valid() {
 		$args = func_get_args();
-		echo "   In " . __METHOD__ . "(" . implode($args, ',') . ")\n";
+		echo "   In " . __METHOD__ . "(" . implode(',', $args) . ")\n";
 		return parent::valid();
 	}
 
 	function current() {
 		$args = func_get_args();
-		echo "   In " . __METHOD__ . "(" . implode($args, ',') . ")\n";
+		echo "   In " . __METHOD__ . "(" . implode(',', $args) . ")\n";
 		return parent::current();
 	}
 
 	function next() {
 		$args = func_get_args();
-		echo "   In " . __METHOD__ . "(" . implode($args, ',') . ")\n";
+		echo "   In " . __METHOD__ . "(" . implode(',', $args) . ")\n";
 		return parent::next();
 	}
 
 	function key() {
 		$args = func_get_args();
-		echo "   In " . __METHOD__ . "(" . implode($args, ',') . ")\n";
+		echo "   In " . __METHOD__ . "(" . implode(',', $args) . ")\n";
 		return parent::key();
 	}
 }
diff --git a/ext/spl/tests/arrayObject_magicMethods5.phpt b/ext/spl/tests/arrayObject_magicMethods5.phpt
index a3c0581bc3..6d2ced3a71 100644
--- a/ext/spl/tests/arrayObject_magicMethods5.phpt
+++ b/ext/spl/tests/arrayObject_magicMethods5.phpt
@@ -16,19 +16,19 @@ class UsesMagic extends ArrayObject {
 
 	function __get($name) {
 		$args = func_get_args();
-		echo "In " . __METHOD__ . "(" . implode($args, ',') . ")\n";
+		echo "In " . __METHOD__ . "(" . implode(',', $args) . ")\n";
 	}
 	function __set($name, $value) {
 		$args = func_get_args();
-		echo "In " . __METHOD__ . "(" . implode($args, ',') . ")\n";
+		echo "In " . __METHOD__ . "(" . implode(',', $args) . ")\n";
 	}
 	function __isset($name) {
 		$args = func_get_args();
-		echo "In " . __METHOD__ . "(" . implode($args, ',') . ")\n";
+		echo "In " . __METHOD__ . "(" . implode(',', $args) . ")\n";
 	}
 	function __unset($name) {
 		$args = func_get_args();
-		echo "In " . __METHOD__ . "(" . implode($args, ',') . ")\n";
+		echo "In " . __METHOD__ . "(" . implode(',', $args) . ")\n";
 	}
 
 }
diff --git a/tests/basic/precision.phpt b/tests/basic/precision.phpt
index 173b94701e..42f99dc9fb 100644
--- a/tests/basic/precision.phpt
+++ b/tests/basic/precision.phpt
@@ -13,7 +13,7 @@ ini_set('serialize_precision', -1);
 echo ini_get('precision'), PHP_EOL;
 echo ini_get('serialize_precision'), PHP_EOL;
 echo "OUTPUTS".PHP_EOL;
-echo join($v, ' ').PHP_EOL;
+echo join(' ', $v).PHP_EOL;
 var_dump(serialize($v));
 var_export($v);echo PHP_EOL;
 
@@ -24,7 +24,7 @@ ini_set('serialize_precision', 0);
 echo ini_get('precision'), PHP_EOL;
 echo ini_get('serialize_precision'), PHP_EOL;
 echo "OUTPUTS".PHP_EOL;
-echo join($v, ' ').PHP_EOL;
+echo join(' ', $v).PHP_EOL;
 var_dump(serialize($v));
 var_export($v);echo PHP_EOL;
 
@@ -34,7 +34,7 @@ ini_set('serialize_precision', 9);
 echo ini_get('precision'), PHP_EOL;
 echo ini_get('serialize_precision'), PHP_EOL;
 echo "OUTPUTS".PHP_EOL;
-echo join($v, ' ').PHP_EOL;
+echo join(' ', $v).PHP_EOL;
 var_dump(serialize($v));
 var_export($v);echo PHP_EOL;
 
@@ -44,7 +44,7 @@ ini_set('serialize_precision', 14);
 echo ini_get('precision'), PHP_EOL;
 echo ini_get('serialize_precision'), PHP_EOL;
 echo "OUTPUTS".PHP_EOL;
-echo join($v, ' ').PHP_EOL;
+echo join(' ', $v).PHP_EOL;
 var_dump(serialize($v));
 var_export($v);echo PHP_EOL;
 
@@ -54,7 +54,7 @@ ini_set('serialize_precision', 17);
 echo ini_get('precision'), PHP_EOL;
 echo ini_get('serialize_precision'), PHP_EOL;
 echo "OUTPUTS".PHP_EOL;
-echo join($v, ' ').PHP_EOL;
+echo join(' ', $v).PHP_EOL;
 var_dump(serialize($v));
 var_export($v);echo PHP_EOL;
 
@@ -64,7 +64,7 @@ ini_set('serialize_precision', 25);
 echo ini_get('precision'), PHP_EOL;
 echo ini_get('serialize_precision'), PHP_EOL;
 echo "OUTPUTS".PHP_EOL;
-echo join($v, ' ').PHP_EOL;
+echo join(' ', $v).PHP_EOL;
 var_dump(serialize($v));
 var_export($v);echo PHP_EOL;
 
@@ -74,7 +74,7 @@ ini_set('serialize_precision', 100);
 echo ini_get('precision'), PHP_EOL;
 echo ini_get('serialize_precision'), PHP_EOL;
 echo "OUTPUTS".PHP_EOL;
-echo join($v, ' ').PHP_EOL;
+echo join(' ', $v).PHP_EOL;
 var_dump(serialize($v));
 var_export($v);echo PHP_EOL;
 --EXPECT--