From: Tom Lane Date: Sun, 24 May 2015 17:03:45 +0000 (-0400) Subject: Rename pg_shdepend.c's typedef "objectType" to SharedDependencyObjectType. X-Git-Tag: REL9_1_17~6 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=2e4c50137a6f96f84d804b41b355e125979e5494;p=postgresql Rename pg_shdepend.c's typedef "objectType" to SharedDependencyObjectType. The name objectType is widely used as a field name, and it's pure luck that this conflict has not caused pgindent to go crazy before. It messed up pg_audit.c pretty good though. Since pg_shdepend.c doesn't export this typedef and only uses it in three places, changing that seems saner than changing the field usages. Back-patch because we're contemplating using the union of all branch typedefs for future pgindent runs, so this won't fix anything if it stays the same in back branches. --- diff --git a/src/backend/catalog/pg_shdepend.c b/src/backend/catalog/pg_shdepend.c index 2df46fa89f..60145ce80d 100644 --- a/src/backend/catalog/pg_shdepend.c +++ b/src/backend/catalog/pg_shdepend.c @@ -62,7 +62,7 @@ typedef enum LOCAL_OBJECT, SHARED_OBJECT, REMOTE_OBJECT -} objectType; +} SharedDependencyObjectType; static void getOidListDiff(Oid *list1, int *nlist1, Oid *list2, int *nlist2); static Oid classIdGetDbId(Oid classId); @@ -79,7 +79,8 @@ static void shdepDropDependency(Relation sdepRel, bool drop_subobjects, Oid refclassId, Oid refobjId, SharedDependencyType deptype); -static void storeObjectDescription(StringInfo descs, objectType type, +static void storeObjectDescription(StringInfo descs, + SharedDependencyObjectType type, ObjectAddress *object, SharedDependencyType deptype, int count); @@ -1057,7 +1058,8 @@ shdepLockAndCheckObject(Oid classId, Oid objectId) * and count to be nonzero; deptype is not used in this case. */ static void -storeObjectDescription(StringInfo descs, objectType type, +storeObjectDescription(StringInfo descs, + SharedDependencyObjectType type, ObjectAddress *object, SharedDependencyType deptype, int count)